Skip to content

[component-emitter] Provide easy access to interface#24994

Merged
mhegazy merged 2 commits intoDefinitelyTyped:masterfrom
FrogTheFrog:master
Apr 14, 2018
Merged

[component-emitter] Provide easy access to interface#24994
mhegazy merged 2 commits intoDefinitelyTyped:masterfrom
FrogTheFrog:master

Conversation

@FrogTheFrog
Copy link
Copy Markdown
Contributor

A simple variable rename to provide easy access to interface.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).
  • Provide a URL to documentation or source code which provides context for the suggested changes:
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 14, 2018

@FrogTheFrog Thank you for submitting this PR!

🔔 @psnider - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@mhegazy mhegazy merged commit 3a647d4 into DefinitelyTyped:master Apr 14, 2018
nossbigg added a commit to nossbigg/DefinitelyTyped that referenced this pull request May 25, 2019
nossbigg added a commit to nossbigg/DefinitelyTyped that referenced this pull request May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants