Skip to content

Fix tapable definition#24996

Merged
johnnyreilly merged 1 commit intoDefinitelyTyped:masterfrom
ooflorent:fix_tapable
Apr 14, 2018
Merged

Fix tapable definition#24996
johnnyreilly merged 1 commit intoDefinitelyTyped:masterfrom
ooflorent:fix_tapable

Conversation

@ooflorent
Copy link
Copy Markdown
Contributor

@ooflorent ooflorent commented Apr 14, 2018

Add missing field in tapable definitions. This is require to use TypeScript on webpack.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@ooflorent
Copy link
Copy Markdown
Contributor Author

cc @johnnyreilly

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Apr 14, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 14, 2018

@ooflorent Thank you for submitting this PR!

🔔 @e-cloud - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@johnnyreilly johnnyreilly merged commit 7f0811a into DefinitelyTyped:master Apr 14, 2018
@johnnyreilly
Copy link
Copy Markdown
Member

Thanks @ooflorent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Popular package This PR affects a popular package (as counted by NPM download counts).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants