Skip to content

[Cucumber] Fix tags property definition in Pickle interface#24843

Merged
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
ClaudiaJ:cucumber-fix-pickle
Apr 14, 2018
Merged

[Cucumber] Fix tags property definition in Pickle interface#24843
mhegazy merged 1 commit intoDefinitelyTyped:masterfrom
ClaudiaJ:cucumber-fix-pickle

Conversation

@ClaudiaJ
Copy link
Copy Markdown
Contributor

@ClaudiaJ ClaudiaJ commented Apr 9, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes:

cucumber-js api-reference.md points at Gherkin library to define a pickle object:

The pickle object comes from the gherkin library. See testdata/good/*.pickles.ndjson for examples of its structure.

Found example of a pickle with tags within tags.feature.pickles.ndjson

  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 9, 2018

@ClaudiaJ Thank you for submitting this PR!

🔔 @AbraaoAlves @jan-molak @isoung @BendingBender @ErikSchierboom - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Apr 9, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@mhegazy mhegazy merged commit cc77534 into DefinitelyTyped:master Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unmerged The author did not merge the PR when it was ready.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants