Skip to content

Add typings for express-ws#24984

Merged
mhegazy merged 9 commits intoDefinitelyTyped:masterfrom
ajliv:express-ws
Apr 14, 2018
Merged

Add typings for express-ws#24984
mhegazy merged 9 commits intoDefinitelyTyped:masterfrom
ajliv:express-ws

Conversation

@ajliv
Copy link
Copy Markdown
Contributor

@ajliv ajliv commented Apr 14, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels Apr 14, 2018
@typescript-bot
Copy link
Copy Markdown
Contributor

typescript-bot commented Apr 14, 2018

@ajliv Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@ajliv
Copy link
Copy Markdown
Contributor Author

ajliv commented Apr 14, 2018

Fixes HenningM/express-ws#78

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Apr 14, 2018
@mhegazy mhegazy merged commit ffbf344 into DefinitelyTyped:master Apr 14, 2018
@ajliv ajliv deleted the express-ws branch April 14, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Definition This PR creates a new definition package. Other Approved This PR was reviewed and signed-off by a community member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants