Skip to content

Conversation

@Inconnu08
Copy link
Owner

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change. If you're changing visual properties, consider including before/after screenshots (and runnable code snippets to reproduce them).

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue database. Indicate, which of these issues are resolved or fixed by this PR.

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A change in behaviour with no test covering it
will likely get reverted accidentally sooner or later. PRs must include tests for all changed/updated/fixed behaviors. See Test Coverage.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

git@github.com:flutter/engine.git/compare/7ea9884ab00e...bbb1f12

git log 7ea9884..bbb1f12 --no-merges --oneline
2019-09-12 50503328+flar@users.noreply.github.com Adjust iOS frame start times to match the platform info (flutter/engine#11802)
2019-09-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (flutter/engine#12231)
2019-09-12 50503328+flar@users.noreply.github.com Revert "Manage iOS contexts separately (#12078)" (flutter/engine#12233)
2019-09-11 gw@gwright.org.uk Manage iOS contexts separately (flutter/engine#12078)
2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (flutter/engine#12224)
2019-09-11 mklim@google.com Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter/engine#12223)
2019-09-11 iska.kaushik@gmail.com Do not generate kernel platform files on topaz tree (flutter/engine#12222)
2019-09-11 hterkelsen@users.noreply.github.com Don't disable toString in release mode for dart:ui classes (flutter/engine#12204)
2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter/engine#12221)
2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter/engine#12220)
2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter/engine#12219)
2019-09-11 iska.kaushik@gmail.com Namespace patched SDK names to not conflict with Topaz (flutter/engine#12218)
2019-09-11 bkonyi@google.com Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits)
2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter/engine#12216)
2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter/engine#12215)
2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter/engine#12214)
2019-09-11 bkonyi@google.com Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits)
2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter/engine#12212)
2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter/engine#12210)
2019-09-11 chinmaygarde@google.com Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter/engine#12209)
2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter/engine#12207)
2019-09-11 chinmaygarde@google.com Only build the x64 variant of Fuchsia on the try-jobs. (flutter/engine#12206)
2019-09-10 hterkelsen@users.noreply.github.com Don't load Roboto by default (flutter/engine#12205)
2019-09-10 bkonyi@google.com Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits)
2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter/engine#12202)
2019-09-10 yjbanov@google.com add a convenience CLI tool for building and testing web engine (flutter/engine#12197)
2019-09-10 jason-simmons@users.noreply.github.com [flutter_runner] Generate symbols for the Dart VM profiler (flutter/engine#12048)
2019-09-10 yjbanov@google.com Add custom test plugin that supports screenshot tests (flutter/engine#12079)
2019-09-10 chinmaygarde@google.com Move the Fuchsia tryjob into a its own step and disable LTO. (flutter/engine#12190)
2019-09-10 bkonyi@google.com Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits)
2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter/engine#12178)
2019-09-10 jason-simmons@users.noreply.github.com [flutter_runner] Port the accessibility bridge from Topaz (flutter/engine#12054)
2019-09-10 liyuqian@google.com Smooth out iOS irregular input events delivery (flutter/engine#11817)
2019-09-10 bkonyi@google.com Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits)
2019-09-10 jonahwilliams@google.com Make ImageShader implement Shader for web ui (flutter/engine#12161)
2019-09-10 bkonyi@google.com Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits)
2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter/engine#12151)
2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter/engine#12129)
2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter/engine#12106)
2019-09-10 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter/engine#12088)
2019-09-10 chinmaygarde@google.com Don't launch the observatory by default on each embedder unit-test invocation. (flutter/engine#12087)
2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter/engine#12086)
2019-09-10 bkonyi@google.com Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits)
2019-09-10 chinmaygarde@google.com Guard availability of user notification related methods to iOS 10.0 (flutter/engine#12084)
2019-09-09 bmparr@google.com Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter/engine#9864)
...
git@github.com:flutter/engine.git/compare/bbb1f124671b...bf91a8d

git log bbb1f12..bf91a8d --no-merges --oneline
2019-09-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (flutter/engine#12238)
2019-09-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (flutter/engine#12237)
2019-09-12 aam@google.com Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (flutter/engine#12235)
2019-09-12 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (flutter/engine#12236)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This was part of a disused tool to explain what did and did not run after reload.
There are overlapping TODAY issues (#40303 and #40114) that prevent this
roll from being split up further.

git log 7ea9884..3c6383f --no-merges --oneline

3c6383f Revert "Smooth out iOS irregular input events delivery (#11817)" (#12251)
d6f0b64 pin and auto-install chrome version (#12228)
2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (#12250)
dfa9498 Enable platform view keyboard input on Android Q (#12085)
bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (#12238)
58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (#12237)
c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (#12235)
cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (#12236)
bbb1f12 Adjust iOS frame start times to match the platform info (#11802)
1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (#12231)
da84d59 Revert "Manage iOS contexts separately (#12078)" (#12233)
4ac0663 Manage iOS contexts separately (#12078)
28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (#12224)
5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (#12223)
988efe3 Do not generate kernel platform files on topaz tree (#12222)
6c46a17 Don't disable toString in release mode for dart:ui classes (#12204)
80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (#12221)
7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (#12220)
c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (#12219)
2bdfb61 Namespace patched SDK names to not conflict with Topaz (#12218)
ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits)
2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (#12216)
d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (#12215)
c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (#12214)
5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits)
e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (#12212)
6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (#12210)
96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (#12209)
34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (#12207)
92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (#12206)
e174b4b Don't load Roboto by default (#12205)
efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits)
5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (#12202)
e9c9984 add a convenience CLI tool for building and testing web engine (#12197)
bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (#12048)
954f198 Add custom test plugin that supports screenshot tests (#12079)
d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (#12190)
c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits)
cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (#12178)
2592d6e [flutter_runner] Port the accessibility bridge from Topaz (#12054)
b569e8c Smooth out iOS irregular input events delivery (#11817)
dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits)
2438798 Make ImageShader implement Shader for web ui (#12161)
c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits)
4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (#12151)
548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (#12129)
f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (#12106)
19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (#12088)
d816755 Don't launch the observatory by default on each embedder unit-test invocation. (#12087)
39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (#12086)
b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits)
03e773a Guard availability of user notification related methods to iOS 10.0 (#12084)
9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (#9864)
c2e8289 Add GradientRadial paintStyle implementation (#12081)
c3eea0a Don't quote generic font families (#12080)
c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (#12082)
a4de006 Remove ENABLE_BITCODE from Scenarios test app (#11839)
6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (#12077)
e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (#12075)
359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (#12074)
38d545e Improve Unicode handling on Windows (#11899)
89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (#12072)
dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (#12071)
8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (#11808)
aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (#12070)
075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (#12068)
a610505 option for --no-lto for fuchsia (#12010)
be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (#12067)
6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (#12059)
e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits)
723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (#12058)
35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)" (#12055)
a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)
c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (#12034)
50bdbd7 Document dependencies and remove support-v13 (#11912)
0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)
37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (#12031)
…40386)

The Dart SDK in this roll is broken.

This reverts commit d4b1f49.
- Makes build_macos.dart handle the case where there is only one Xcode
  project in the macos/ directory, but it's not called Runner.xcodeproj
- Makes getInfo throw a tool exit when trying to get project info and it
  can't find a project, since that is a configuration error by the user
  rather than a tool bug.
Changes since last roll:
```
6e6de94 Roll dart to d9489622befb638c040975163cf9b8eba2ff057b. (#12255)
5c86111 [glfw/windows] Stops keeping track of input models (#12234)
9c84659 Editable text fix (#12249)
cce4b5b Roll src/third_party/dart e6887536aa..c74e68e501 (14 commits)
55c346a Roll fuchsia/sdk/core/linux-amd64 from vuG5q... to 6a4X4... (#12252)
6beba53 Started taking advantage of Skia's new copyTableData to avoid (#10154)
3c6383f Revert "Smooth out iOS irregular input events delivery (#11817)" (#12251)
d6f0b64 pin and auto-install chrome version (#12228)
2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (#12250)
dfa9498 Enable platform view keyboard input on Android Q (#12085)
bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (#12238)
58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (#12237)
c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (#12235)
cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (#12236)
bbb1f12 Adjust iOS frame start times to match the platform info (#11802)
1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (#12231)
da84d59 Revert "Manage iOS contexts separately (#12078)" (#12233)
4ac0663 Manage iOS contexts separately (#12078)
28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (#12224)
5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (#12223)
988efe3 Do not generate kernel platform files on topaz tree (#12222)
6c46a17 Don't disable toString in release mode for dart:ui classes (#12204)
80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (#12221)
7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (#12220)
c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (#12219)
2bdfb61 Namespace patched SDK names to not conflict with Topaz (#12218)
ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits)
2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (#12216)
d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (#12215)
c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (#12214)
5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits)
e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (#12212)
6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (#12210)
96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (#12209)
34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (#12207)
92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (#12206)
e174b4b Don't load Roboto by default (#12205)
efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits)
5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (#12202)
e9c9984 add a convenience CLI tool for building and testing web engine (#12197)
bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (#12048)
954f198 Add custom test plugin that supports screenshot tests (#12079)
d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (#12190)
c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits)
cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (#12178)
2592d6e [flutter_runner] Port the accessibility bridge from Topaz (#12054)
b569e8c Smooth out iOS irregular input events delivery (#11817)
dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits)
2438798 Make ImageShader implement Shader for web ui (#12161)
c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits)
4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (#12151)
548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (#12129)
f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (#12106)
19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (#12088)
d816755 Don't launch the observatory by default on each embedder unit-test invocation. (#12087)
39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (#12086)
b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits)
03e773a Guard availability of user notification related methods to iOS 10.0 (#12084)
9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (#9864)
c2e8289 Add GradientRadial paintStyle implementation (#12081)
c3eea0a Don't quote generic font families (#12080)
c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (#12082)
a4de006 Remove ENABLE_BITCODE from Scenarios test app (#11839)
6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (#12077)
e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (#12075)
359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (#12074)
38d545e Improve Unicode handling on Windows (#11899)
89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (#12072)
dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (#12071)
8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (#11808)
aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (#12070)
075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (#12068)
a610505 option for --no-lto for fuchsia (#12010)
be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (#12067)
6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (#12059)
e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits)
723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (#12058)
35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)" (#12055)
a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)
c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (#12034)
50bdbd7 Document dependencies and remove support-v13 (#11912)
0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)
37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (#12031)
```
This re-introduced 32 bit iOS failures.

This reverts commit c37d06c.
On macOS and iOS, the build mode is converted to lowercase in the
Flutter-side script, allowing projects to pass configuration names
directly. This adds the same behavior to the tool_backend.dart script
currently used by Windows and Linux, so that Windows builds can do the
same (since the default configuration names used by VS, as in Xcode,
start with a capital letter).
…meter (#39857)

* Add constraints property, updated default constraints for ToggleButtons to 48x48

* Add kMinInteractiveDimension constant to ToggleButtons
1b63444 Revert "Started taking advantage of Skia's new copyTableData to avoid (#10154)" (#12263)
0897b50 Roll fuchsia/sdk/core/linux-amd64 from 6a4X4... to Xfeuz... (#12261)
186014c Roll src/third_party/skia be194479d27f..043dba039e0d (23 commits) (#12262)
4debdda Roll fuchsia/sdk/core/mac-amd64 from JVZ_i... to gVBCH... (#12260)
9e7bd05 Roll src/third_party/dart d9489622be..a554c8be6b (10 commits)
850d80c Revert "Add some AppLifecycleTests (#11890)" (#12264)
46ff053 Add some AppLifecycleTests (#11890)
ca4c3f6 Add an initial macOS version of FlutterAppDelegate (#12230)
6e6de94 Roll dart to d9489622befb638c040975163cf9b8eba2ff057b. (#12255)
5c86111 [glfw/windows] Stops keeping track of input models (#12234)
9c84659 Editable text fix (#12249)
cce4b5b Roll src/third_party/dart e6887536aa..c74e68e501 (14 commits)
55c346a Roll fuchsia/sdk/core/linux-amd64 from vuG5q... to 6a4X4... (#12252)
6beba53 Started taking advantage of Skia's new copyTableData to avoid (#10154)
3c6383f Revert "Smooth out iOS irregular input events delivery (#11817)" (#12251)
d6f0b64 pin and auto-install chrome version (#12228)
2698a0e Roll fuchsia/sdk/core/mac-amd64 from Ne2UA... to JVZ_i... (#12250)
dfa9498 Enable platform view keyboard input on Android Q (#12085)
bf91a8d Roll fuchsia/sdk/core/linux-amd64 from u7Q31... to vuG5q... (#12238)
58ecf52 Roll src/third_party/skia 7c47d41067d4..be194479d27f (4 commits) (#12237)
c71580b Roll dart to e6887536aadc7fbd1990448989601cee0224958d. (#12235)
cf1d156 Roll fuchsia/sdk/core/mac-amd64 from _nS67... to Ne2UA... (#12236)
bbb1f12 Adjust iOS frame start times to match the platform info (#11802)
1de28d0 Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (#12231)
da84d59 Revert "Manage iOS contexts separately (#12078)" (#12233)
4ac0663 Manage iOS contexts separately (#12078)
28d7900 Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (#12224)
5b94c8a Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (#12223)
988efe3 Do not generate kernel platform files on topaz tree (#12222)
6c46a17 Don't disable toString in release mode for dart:ui classes (#12204)
80b8ed8 Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (#12221)
7a8caaa Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (#12220)
c8428ff Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (#12219)
2bdfb61 Namespace patched SDK names to not conflict with Topaz (#12218)
ff1fcfb Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits)
2b78c59 Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (#12216)
d74ed76 Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (#12215)
c58c593 Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (#12214)
5e85403 Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits)
e2cc04c Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (#12212)
6fbfb45 Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (#12210)
96443e2 Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (#12209)
34cf4f7 Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (#12207)
92d42c0 Only build the x64 variant of Fuchsia on the try-jobs. (#12206)
e174b4b Don't load Roboto by default (#12205)
efb32a6 Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits)
5566be1 Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (#12202)
e9c9984 add a convenience CLI tool for building and testing web engine (#12197)
bfa43e1 [flutter_runner] Generate symbols for the Dart VM profiler (#12048)
954f198 Add custom test plugin that supports screenshot tests (#12079)
d8379f9 Move the Fuchsia tryjob into a its own step and disable LTO. (#12190)
c12ac24 Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits)
cab3a39 Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (#12178)
2592d6e [flutter_runner] Port the accessibility bridge from Topaz (#12054)
b569e8c Smooth out iOS irregular input events delivery (#11817)
dea813d Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits)
2438798 Make ImageShader implement Shader for web ui (#12161)
c31583a Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits)
4542886 Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (#12151)
548998f Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (#12129)
f1490a2 Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (#12106)
19b2d43 Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (#12088)
d816755 Don't launch the observatory by default on each embedder unit-test invocation. (#12087)
39c8067 Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (#12086)
b19e75a Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits)
03e773a Guard availability of user notification related methods to iOS 10.0 (#12084)
9c00c26 Add capability to add AppDelegate as UNUserNotificationCenterDelegate (#9864)
c2e8289 Add GradientRadial paintStyle implementation (#12081)
c3eea0a Don't quote generic font families (#12080)
c2b3d88 Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (#12082)
a4de006 Remove ENABLE_BITCODE from Scenarios test app (#11839)
6e017f0 Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (#12077)
e911b05 Roll src/third_party/skia 627d15588f4d..4f2674da4bbc (1 commits) (#12075)
359e663 Roll src/third_party/skia 6c3bd09ead0f..627d15588f4d (3 commits) (#12074)
38d545e Improve Unicode handling on Windows (#11899)
89efb4c Roll fuchsia/clang/linux-amd64 from VoYNW... to 2IT_b... (#12072)
dc8e30d Roll fuchsia/clang/mac-amd64 from XAazI... to H1Qjc... (#12071)
8cdb3af Annotate nullability on FlutterEngine to make swift writing more ergonomic (#11808)
aa9aaa2 Roll src/third_party/skia f433336585ed..6c3bd09ead0f (1 commits) (#12070)
075a61f Roll src/third_party/skia 69a426f5a427..f433336585ed (1 commits) (#12068)
a610505 option for --no-lto for fuchsia (#12010)
be39820 Roll src/third_party/skia 380561393385..69a426f5a427 (2 commits) (#12067)
6bafbf9 Roll src/third_party/skia c30f1a936d84..380561393385 (3 commits) (#12059)
e2ba93d Roll src/third_party/dart ec7ec4ecf7..fb14babf59 (19 commits)
723a288 Roll fuchsia/clang/linux-amd64 from -mnHl... to VoYNW... (#12058)
35875e0 Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)" (#12055)
a353f93 Manage resource and onscreen contexts using separate IOSGLContext objects (#11798)
c9ea4db [flutter_runner] Refactor our build rules to make them more inline with topaz. (#12034)
50bdbd7 Document dependencies and remove support-v13 (#11912)
0c6a538 Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)
37f81cd Roll src/third_party/skia 080d210e7acc..c30f1a936d84 (21 commits) (#12031)
git@github.com:flutter/engine.git/compare/1b6344439062...7d8c6d9

git log 1b63444..7d8c6d9 --no-merges --oneline
2019-09-13 xster@google.com Reland add some AppLifecycleTests


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
git@github.com:flutter/engine.git/compare/7d8c6d9c1a5c...e12decf

git log 7d8c6d9..e12decf --no-merges --oneline
2019-09-13 xster@google.com Clean up after AppLifecycleTests (flutter/engine#12273)
2019-09-13 dnfield@google.com Close the tree (flutter/engine#12268)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
krisgiesing and others added 27 commits September 27, 2019 10:48
ReorderableListView was constructing a GlobalObjectKey using
the child key as the value. This only had the intended behavior
if the child key was identical across build method invocations.

The new strategy is to scope the child key's value to the
State object's identity, allowing child keys to have value
compare semantics while disambiguating among different list view
instances.
This reverts the engine to a previous hash because of #41484
This adds a description of the command needed to run the driver test
* remove splash logic

* update tests
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
This reverts commit baea9bf.

Additionally,   we let the test run on mac8 with iphonexs because the test won't run on Xcode 10.1 (mac3-7). Hence we force it to run on mac8 which currently has Xcode 10.2.
* Retry devfs uploads in case they fail.

Fixes #34959.
)

* Fix visbility of web server device when Chrome is not available

* Add tests

* Update workflow test

* Fix tests to not rely on Chrome being on the underlying machine
#41493)

* [flutter_tool] Report to analytics when the tool is killed by a signal

* Fix analyzer lint
* set the copyWith toggleButtonsTheme argument type to ToggleButtonsThemeData

* add a ThemeData.copyWith test
Currently Linux builds override the default BUILD mode by putting it in
the generated config. That makes it sticky for manual runs of make,
which is inconsistent with how other platforms work.

Instead, pass the build mode as a command-line override, the same way
someone would if building directly with make. This makes the flow of
controlling the mode less confusing.

Fixes #41528
* add missing trailing commas

* add more missing trailing commas

* add more and more missing trailing commas
@Inconnu08 Inconnu08 merged commit 9751ac8 into Inconnu08:master Sep 30, 2019
Inconnu08 pushed a commit that referenced this pull request Oct 29, 2019
…#42640)

* Add structured errors in Animations, TabView, ChangeNotifier

* Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan

* Add structured errors in Debug

* Fix test errors

* Add structured errors in Scaffold and Stepper

* Add structured errors in part of Rendering Layer

* Fix failing test due to FloatingPoint precision

* Fix failing tests due to precision error and not using final

* Fix failing test due to floating precision error with RegEx instead

* Add structured error in CustomLayout and increase test coverage

* Add structured error & its test in ListBody

* Add structured error in ProxyBox and increase test coverage

* Add structured error message in Viewport

* Fix styles and add more assertions on ErrorHint and DiagnosticProperty

* Add structured error in scheduler/binding and scheduler/ticker

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in AssetBundle and TextInput

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured errors in several widgets #1

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove unused import

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add assertions on hint messages

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix catch spacing

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in several widgets part 2 and increase code coverage

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in flutter_test/widget_tester

* Fix floating precision accuracy by using RegExp

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove todo to add tests in Scaffold showBottomSheet

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix reviews by indenting lines and fixing the assertion orders

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix failing tests due to renaming class

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Try skipping the NetworkBundleTest

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove leading space in material/debug error hint

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
Inconnu08 pushed a commit that referenced this pull request Nov 26, 2019
…#42640)

* Add structured errors in Animations, TabView, ChangeNotifier

* Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan

* Add structured errors in Debug

* Fix test errors

* Add structured errors in Scaffold and Stepper

* Add structured errors in part of Rendering Layer

* Fix failing test due to FloatingPoint precision

* Fix failing tests due to precision error and not using final

* Fix failing test due to floating precision error with RegEx instead

* Add structured error in CustomLayout and increase test coverage

* Add structured error & its test in ListBody

* Add structured error in ProxyBox and increase test coverage

* Add structured error message in Viewport

* Fix styles and add more assertions on ErrorHint and DiagnosticProperty

* Add structured error in scheduler/binding and scheduler/ticker

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in AssetBundle and TextInput

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured errors in several widgets #1

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove unused import

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add assertions on hint messages

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix catch spacing

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in several widgets part 2 and increase code coverage

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Add structured error in flutter_test/widget_tester

* Fix floating precision accuracy by using RegExp

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove todo to add tests in Scaffold showBottomSheet

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix reviews by indenting lines and fixing the assertion orders

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Fix failing tests due to renaming class

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Try skipping the NetworkBundleTest

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>

* Remove leading space in material/debug error hint

Signed-off-by: Albertus Angga Raharja <albertusangga@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.