Smooth out iOS irregular input events delivery #11817

liyuqian · 2019-09-01T20:08:00Z

This patch is a lower level implementation of
flutter/flutter#36616 that would only impact iOS
engine, and host unittests.

Fixes flutter/flutter#31086 This patch is a lower level implementation of flutter/flutter#36616 that would only impact iOS engine, and host unittests.

chinmaygarde

I am still reviewing the patch but the immediate feedback is that we don't patch "shell/common" classes with platform specific behavior. Please move the same to PlatformView<Foo>

chinmaygarde · 2019-09-03T22:09:00Z

shell/common/engine.cc

+    uint64_t trace_flow_id) {
  TRACE_EVENT0("flutter", "Engine::DispatchPointerDataPacket");
  TRACE_FLOW_STEP("flutter", "PointerEvent", trace_flow_id);
+#ifdef ENABLE_IRREGULAR_INPUT_DELIVERY_FIX


Please perform this sanitization on the platform task runner and in the platform specific subclass for the entrypoint of these events into the engine. In this case, it would be PlatformViewIOS. We don't apply platform specific hacks in the "common" classes. This will also get rid of the the ENABLE_IRREGULAR_INPUT_DELIVERY_FIX.

chinmaygarde · 2019-09-03T22:15:07Z

shell/common/shell_test.h

+  //
+  // The test here is insensitive to the choice of time unit as long as
+  // delivery_time and frame_time are in the same unit.
+  void TestSimulatedInputEvents(int num_events,


This test utility can be moved into the TU that defines the test itself and out of the fixture.

chinmaygarde · 2019-09-03T22:32:46Z

We had a conversation offline to rework this so that platform specific stuff doesn't end up in the common classes but is also tested on all platforms.

And let the PlatforView decide which PointerDataDispatcher is used.

liyuqian · 2019-09-04T21:45:40Z

@chinmaygarde : this is ready for review again.

chinmaygarde

Getting closer. Just a few more nits. Thanks.

chinmaygarde · 2019-09-06T23:59:35Z

shell/common/engine.cc

  );
+
+  pointer_data_dispatcher_ =
+      platform_view.MakePointerDataDispatcher(*animator_, *runtime_controller_);


Platform view methods can only be accessed on the platform task runner. Maybe create the dispatcher in the Shell::Create call on the platform task runner and pass the same to the engine in the constructor? You could then set the animator and the the runtime controller on the dispatcher if one is provided here. The dispatcher can be a thread safe object.

Done. I sent in a std::function<std::unique_ptr<PointerDataDispatcher>(...)> instead of a PointerDataDispatcher because Animator& and RuntimeController& must be initialized at construction.

chinmaygarde · 2019-09-07T00:00:53Z

shell/common/pointer_data_dispatcher.h

+
+namespace flutter {
+
+class PointerDataDispatcher {


Please document this classes in the doxygen format. See shell.h for an example. Please be sure to document the threading restrictions and lifecycle of these objects.

chinmaygarde · 2019-09-07T00:02:31Z

shell/common/pointer_data_dispatcher.h

+ protected:
+  RuntimeController& runtime_controller_;
+  Animator& animator_;
+};


DISALLOW_COPY_AND_ASSIGN

chinmaygarde · 2019-09-07T00:03:07Z

shell/common/pointer_data_dispatcher.h

+
+  void DispatchPacket(std::unique_ptr<PointerDataPacket> packet,
+                      uint64_t trace_flow_id) override;
+  void OnRender() override {}  // Intentional no-op


Please make virtual's OOL.

chinmaygarde · 2019-09-07T00:03:19Z

shell/common/pointer_data_dispatcher.h

+                      uint64_t trace_flow_id) override;
+  void OnRender() override {}  // Intentional no-op
+
+  virtual ~DefaultPointerDataDispatcher() {}


Please OOL destructors.

chinmaygarde · 2019-09-07T00:12:24Z

shell/common/input_events_unittests.cc

+
+using Generator = std::function<int(int)>;
+
+// Simulate n input events where the i-th one is delivered at


Thanks for the concise description. Please put these in doxygen format though so these end up being searchable in the docs for the test.

chinmaygarde · 2019-09-07T00:15:10Z

shell/common/input_events_unittests.cc

+namespace flutter {
+namespace testing {
+
+using Generator = std::function<int(int)>;


I realize the units dont matter, but can you make these be points anyway? Makes this clearer to read than just an int.

Did you forget to push this? I still see these as ints. In any case, it was a nit.

Ah, I probably misunderstood your previous comment and only added a comment. Now I've used UnitlessTime to make it more clear.

chinmaygarde · 2019-09-07T00:17:10Z

shell/common/input_events_unittests.cc

+  // Actual delivery times measured on iPhone Xs, in the unit of frame_time
+  // (16.67ms for 60Hz).
+  constexpr int n = 47;
+  constexpr double iphone_xs_times[n] = {0.15,


You can get rid of n = 47 and instead write sizeof(iphonx_xs_times) / sizeof(double) or arraysize. That way, we can add and remove items from this fixture without potentially forgetting to update the size. These are known at compile time anyway.

chinmaygarde · 2019-09-07T00:19:01Z

shell/common/pointer_data_dispatcher.h

+  Animator& animator_;
+};
+
+class IosPointerDataDispatcher : public DefaultPointerDataDispatcher {


The documentation you added inline in the implementation of the DispatchPacket can be added here instead in doxygen format to clarify the purpose if this class. Also, maybe a more descriptive name for this class would be better. One that describes what this class does and not where this class is used.

chinmaygarde · 2019-09-07T00:19:39Z

shell/common/pointer_data_dispatcher.h

+  void DispatchPendingPacket();
+};
+
+}  // namespace flutter


DISALLOW_COPY_AND_ASSIGN

liyuqian

Thanks for the comments! I've revised accordingly. Please check if I missed anything :-)

liyuqian · 2019-09-08T05:03:35Z

shell/common/pointer_data_dispatcher.h

+
+namespace flutter {
+
+class PointerDataDispatcher {


liyuqian · 2019-09-08T05:03:49Z

shell/common/pointer_data_dispatcher.h

+ public:
+  virtual void DispatchPacket(std::unique_ptr<PointerDataPacket> packet,
+                              uint64_t trace_flow_id) = 0;
+  virtual void OnRender() = 0;


liyuqian · 2019-09-08T05:16:51Z

shell/common/pointer_data_dispatcher.h

+  virtual void DispatchPacket(std::unique_ptr<PointerDataPacket> packet,
+                              uint64_t trace_flow_id) = 0;
+  virtual void OnRender() = 0;
+  virtual ~PointerDataDispatcher() {}


liyuqian · 2019-09-08T05:17:12Z

shell/common/pointer_data_dispatcher.h

+                               RuntimeController& runtime_controller)
+      : runtime_controller_(runtime_controller), animator_(animator) {}
+
+  void DispatchPacket(std::unique_ptr<PointerDataPacket> packet,


liyuqian · 2019-09-08T05:18:35Z

shell/common/pointer_data_dispatcher.h

+
+  void DispatchPacket(std::unique_ptr<PointerDataPacket> packet,
+                      uint64_t trace_flow_id) override;
+  void OnRender() override {}  // Intentional no-op


liyuqian · 2019-09-08T19:00:10Z

shell/common/engine.cc

  );
+
+  pointer_data_dispatcher_ =
+      platform_view.MakePointerDataDispatcher(*animator_, *runtime_controller_);


Done. I sent in a std::function<std::unique_ptr<PointerDataDispatcher>(...)> instead of a PointerDataDispatcher because Animator& and RuntimeController& must be initialized at construction.

liyuqian · 2019-09-08T19:02:49Z

shell/common/input_events_unittests.cc

+namespace flutter {
+namespace testing {
+
+using Generator = std::function<int(int)>;


liyuqian · 2019-09-08T19:08:33Z

shell/common/input_events_unittests.cc

+
+using Generator = std::function<int(int)>;
+
+// Simulate n input events where the i-th one is delivered at


liyuqian · 2019-09-08T19:11:11Z

shell/common/input_events_unittests.cc

+  // Actual delivery times measured on iPhone Xs, in the unit of frame_time
+  // (16.67ms for 60Hz).
+  constexpr int n = 47;
+  constexpr double iphone_xs_times[n] = {0.15,


liyuqian · 2019-09-08T19:22:20Z

shell/common/pointer_data_dispatcher.h

+  Animator& animator_;
+};
+
+class IosPointerDataDispatcher : public DefaultPointerDataDispatcher {


chinmaygarde

All nits and most about docs. lgtm once those are fixed. Thanks.

chinmaygarde · 2019-09-09T22:23:25Z

shell/common/engine.cc

      std::move(isolate_snapshot),           // isolate snapshot
      std::move(shared_snapshot),            // shared snapshot
-      std::move(task_runners),               // task runners
+      task_runners,                          // task runners


There is a story of suffering behind this isn't there :)

chinmaygarde · 2019-09-09T22:25:33Z

shell/common/input_events_unittests.cc

+namespace flutter {
+namespace testing {
+
+using Generator = std::function<int(int)>;


Did you forget to push this? I still see these as ints. In any case, it was a nit.

chinmaygarde · 2019-09-09T22:26:24Z

shell/common/platform_view.h

-  ///
-  /// @param[in]  closure  The callback to execute on the render thread when the
+  /// @brief      Sets a callback that gets executed when the rasterizer
+  /// renders


Incorrect word wrapping.

chinmaygarde · 2019-09-09T22:26:27Z

shell/common/platform_view.h

  //----------------------------------------------------------------------------
-  /// @brief      Gives embedders a chance to react to a "cold restart" of the
+  /// @brief      Gives embedders a chance to react to a "cold restart" of
+  /// the


Incorrect word wrapping.

chinmaygarde · 2019-09-09T22:26:31Z

shell/common/platform_view.h

+  ///             re-thread as necessary.
+  ///
+  /// @attention  The callback is executed on the render task runner and not
+  /// the


Incorrect word wrapping.

chinmaygarde · 2019-09-09T22:26:34Z

shell/common/platform_view.h

+  ///             necessary.
+  ///
+  /// @param[in]  closure  The callback to execute on the render thread when
+  /// the


Incorrect word wrapping.

chinmaygarde · 2019-09-09T22:26:37Z

shell/common/platform_view.h

  ///
-  /// @param[in]  packet  The pointer data packet to dispatch to the framework.
+  /// @param[in]  packet  The pointer data packet to dispatch to the
+  /// framework.


Incorrect word wrapping.

chinmaygarde · 2019-09-09T22:26:41Z

shell/common/platform_view.h

-  ///                         the texture has not been previously registered,
-  ///                         this call does nothing.
+  /// @param[in]  texture_id  The identifier of the texture to unregister.
+  /// If


Incorrect word wrapping.

chinmaygarde · 2019-09-09T22:26:44Z

shell/common/platform_view.h

  //--------------------------------------------------------------------------
-  /// @brief      Used by the embedder to notify the rasterizer that the context
+  /// @brief      Used by the embedder to notify the rasterizer that the
+  /// context


Incorrect word wrapping.

chinmaygarde · 2019-09-09T22:27:45Z

shell/common/engine.h

  ///                                tasks that require access to components
  ///                                that cannot be safely accessed by the
  ///                                engine. This is the shell.
+  /// @param      platform_view      The object used by engine to create the


This param is now out of date. Please also make sure to specify the updated threading restrictions when you fix this.

liyuqian

What has clang-format done to my headers... Thank you for being smarter than clang-format! 😄

chinmaygarde · 2019-09-09T23:32:30Z

What has clang-format done to my headers

If you correctly indent the second line, it matches the indentation correctly for all following lines. If the first line overflows, then stuff gets weird.

…e#11817)

git@github.com:flutter/engine.git/compare/7ea9884ab00e...5b94c8a git log 7ea9884..5b94c8a --no-merges --oneline 2019-09-11 mklim@google.com Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter/engine#12223) 2019-09-11 iska.kaushik@gmail.com Do not generate kernel platform files on topaz tree (flutter/engine#12222) 2019-09-11 hterkelsen@users.noreply.github.com Don't disable toString in release mode for dart:ui classes (flutter/engine#12204) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter/engine#12221) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter/engine#12220) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter/engine#12219) 2019-09-11 iska.kaushik@gmail.com Namespace patched SDK names to not conflict with Topaz (flutter/engine#12218) 2019-09-11 bkonyi@google.com Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter/engine#12216) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter/engine#12215) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter/engine#12214) 2019-09-11 bkonyi@google.com Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter/engine#12212) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter/engine#12210) 2019-09-11 chinmaygarde@google.com Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter/engine#12209) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter/engine#12207) 2019-09-11 chinmaygarde@google.com Only build the x64 variant of Fuchsia on the try-jobs. (flutter/engine#12206) 2019-09-10 hterkelsen@users.noreply.github.com Don't load Roboto by default (flutter/engine#12205) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter/engine#12202) 2019-09-10 yjbanov@google.com add a convenience CLI tool for building and testing web engine (flutter/engine#12197) 2019-09-10 jason-simmons@users.noreply.github.com [flutter_runner] Generate symbols for the Dart VM profiler (flutter/engine#12048) 2019-09-10 yjbanov@google.com Add custom test plugin that supports screenshot tests (flutter/engine#12079) 2019-09-10 chinmaygarde@google.com Move the Fuchsia tryjob into a its own step and disable LTO. (flutter/engine#12190) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter/engine#12178) 2019-09-10 jason-simmons@users.noreply.github.com [flutter_runner] Port the accessibility bridge from Topaz (flutter/engine#12054) 2019-09-10 liyuqian@google.com Smooth out iOS irregular input events delivery (flutter/engine#11817) 2019-09-10 bkonyi@google.com Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2019-09-10 jonahwilliams@google.com Make ImageShader implement Shader for web ui (flutter/engine#12161) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter/engine#12151) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter/engine#12129) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter/engine#12106) 2019-09-10 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter/engine#12088) 2019-09-10 chinmaygarde@google.com Don't launch the observatory by default on each embedder unit-test invocation. (flutter/engine#12087) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter/engine#12086) 2019-09-10 bkonyi@google.com Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 2019-09-10 chinmaygarde@google.com Guard availability of user notification related methods to iOS 10.0 (flutter/engine#12084) 2019-09-09 bmparr@google.com Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter/engine#9864) 2019-09-09 ferhat@gmail.com Add GradientRadial paintStyle implementation (flutter/engine#12081) 2019-09-09 hterkelsen@users.noreply.github.com Don't quote generic font families (flutter/engine#12080) 2019-09-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 28d40b2e7ade..c2d84bfa7421 (3 commits) (flutter/engine#12082) 2019-09-09 magder@google.com Remove ENABLE_BITCODE from Scenarios test app (flutter/engine#11839) 2019-09-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4f2674da4bbc..28d40b2e7ade (4 commits) (flutter/engine#12077) ...

…e#11817)

git@github.com:flutter/engine.git/compare/7ea9884ab00e...bbb1f12 git log 7ea9884..bbb1f12 --no-merges --oneline 2019-09-12 50503328+flar@users.noreply.github.com Adjust iOS frame start times to match the platform info (flutter/engine#11802) 2019-09-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (flutter/engine#12231) 2019-09-12 50503328+flar@users.noreply.github.com Revert "Manage iOS contexts separately (#12078)" (flutter/engine#12233) 2019-09-11 gw@gwright.org.uk Manage iOS contexts separately (flutter/engine#12078) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (flutter/engine#12224) 2019-09-11 mklim@google.com Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter/engine#12223) 2019-09-11 iska.kaushik@gmail.com Do not generate kernel platform files on topaz tree (flutter/engine#12222) 2019-09-11 hterkelsen@users.noreply.github.com Don't disable toString in release mode for dart:ui classes (flutter/engine#12204) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter/engine#12221) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter/engine#12220) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter/engine#12219) 2019-09-11 iska.kaushik@gmail.com Namespace patched SDK names to not conflict with Topaz (flutter/engine#12218) 2019-09-11 bkonyi@google.com Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter/engine#12216) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter/engine#12215) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter/engine#12214) 2019-09-11 bkonyi@google.com Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter/engine#12212) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter/engine#12210) 2019-09-11 chinmaygarde@google.com Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter/engine#12209) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter/engine#12207) 2019-09-11 chinmaygarde@google.com Only build the x64 variant of Fuchsia on the try-jobs. (flutter/engine#12206) 2019-09-10 hterkelsen@users.noreply.github.com Don't load Roboto by default (flutter/engine#12205) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter/engine#12202) 2019-09-10 yjbanov@google.com add a convenience CLI tool for building and testing web engine (flutter/engine#12197) 2019-09-10 jason-simmons@users.noreply.github.com [flutter_runner] Generate symbols for the Dart VM profiler (flutter/engine#12048) 2019-09-10 yjbanov@google.com Add custom test plugin that supports screenshot tests (flutter/engine#12079) 2019-09-10 chinmaygarde@google.com Move the Fuchsia tryjob into a its own step and disable LTO. (flutter/engine#12190) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter/engine#12178) 2019-09-10 jason-simmons@users.noreply.github.com [flutter_runner] Port the accessibility bridge from Topaz (flutter/engine#12054) 2019-09-10 liyuqian@google.com Smooth out iOS irregular input events delivery (flutter/engine#11817) 2019-09-10 bkonyi@google.com Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2019-09-10 jonahwilliams@google.com Make ImageShader implement Shader for web ui (flutter/engine#12161) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter/engine#12151) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter/engine#12129) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter/engine#12106) 2019-09-10 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter/engine#12088) 2019-09-10 chinmaygarde@google.com Don't launch the observatory by default on each embedder unit-test invocation. (flutter/engine#12087) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter/engine#12086) 2019-09-10 bkonyi@google.com Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 2019-09-10 chinmaygarde@google.com Guard availability of user notification related methods to iOS 10.0 (flutter/engine#12084) 2019-09-09 bmparr@google.com Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter/engine#9864) ...

) This reverts commit b569e8c.

…er#11817)" (flutter#12251)" This reverts commit 3c6383f.

) Additionally, we now use the engine directly as a delegate instead of storing potentially dead runtime_controller. Unit tests have been updated to include an engine restart check which would fail before the fix. This fixes flutter/flutter#40303

…er#11817)" (flutter#12280)" This reverts commit aac33d1.

…" (#12280)" (#12364) This reverts commit aac33d1. Reason: flutter/flutter#40863 TBR: chinmaygarde, iskakaushik

git@github.com:flutter/engine.git/compare/7ea9884ab00e...bbb1f12 git log 7ea9884..bbb1f12 --no-merges --oneline 2019-09-12 50503328+flar@users.noreply.github.com Adjust iOS frame start times to match the platform info (flutter/engine#11802) 2019-09-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 50f377e275c3..7c47d41067d4 (3 commits) (flutter/engine#12231) 2019-09-12 50503328+flar@users.noreply.github.com Revert "Manage iOS contexts separately (flutter#12078)" (flutter/engine#12233) 2019-09-11 gw@gwright.org.uk Manage iOS contexts separately (flutter/engine#12078) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 120e7d6766e4..50f377e275c3 (7 commits) (flutter/engine#12224) 2019-09-11 mklim@google.com Revert "Roll src/third_party/dart be66176534..ec7ec4ecf7 (37 commits)" (flutter/engine#12223) 2019-09-11 iska.kaushik@gmail.com Do not generate kernel platform files on topaz tree (flutter/engine#12222) 2019-09-11 hterkelsen@users.noreply.github.com Don't disable toString in release mode for dart:ui classes (flutter/engine#12204) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 7gDBN... to u7Q31... (flutter/engine#12221) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia d96ef09317d6..120e7d6766e4 (2 commits) (flutter/engine#12220) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from vDk46... to _nS67... (flutter/engine#12219) 2019-09-11 iska.kaushik@gmail.com Namespace patched SDK names to not conflict with Topaz (flutter/engine#12218) 2019-09-11 bkonyi@google.com Roll src/third_party/dart ca7baa4013..4d5e15abde (29 commits) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 14318c140949..d96ef09317d6 (2 commits) (flutter/engine#12216) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia b23a4f9d9442..14318c140949 (2 commits) (flutter/engine#12215) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 26ac0467cb4c..b23a4f9d9442 (2 commits) (flutter/engine#12214) 2019-09-11 bkonyi@google.com Roll src/third_party/dart 7bbfd532de..ca7baa4013 (3 commits) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from R1yqu... to 7gDBN... (flutter/engine#12212) 2019-09-11 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from spUG2... to vDk46... (flutter/engine#12210) 2019-09-11 chinmaygarde@google.com Roll buildroot and Fuchsia toolchain and unblock the Fuchsia/Linux autoroller manually. (flutter/engine#12209) 2019-09-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4fe30e15c06c..26ac0467cb4c (2 commits) (flutter/engine#12207) 2019-09-11 chinmaygarde@google.com Only build the x64 variant of Fuchsia on the try-jobs. (flutter/engine#12206) 2019-09-10 hterkelsen@users.noreply.github.com Don't load Roboto by default (flutter/engine#12205) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 300c3333d1..7bbfd532de (5 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 66d8006c2bb1..4fe30e15c06c (11 commits) (flutter/engine#12202) 2019-09-10 yjbanov@google.com add a convenience CLI tool for building and testing web engine (flutter/engine#12197) 2019-09-10 jason-simmons@users.noreply.github.com [flutter_runner] Generate symbols for the Dart VM profiler (flutter/engine#12048) 2019-09-10 yjbanov@google.com Add custom test plugin that supports screenshot tests (flutter/engine#12079) 2019-09-10 chinmaygarde@google.com Move the Fuchsia tryjob into a its own step and disable LTO. (flutter/engine#12190) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 62f78a7abb..300c3333d1 (6 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia b88894c8811b..66d8006c2bb1 (5 commits) (flutter/engine#12178) 2019-09-10 jason-simmons@users.noreply.github.com [flutter_runner] Port the accessibility bridge from Topaz (flutter/engine#12054) 2019-09-10 liyuqian@google.com Smooth out iOS irregular input events delivery (flutter/engine#11817) 2019-09-10 bkonyi@google.com Roll src/third_party/dart ccb6ba948b..62f78a7abb (3 commits) 2019-09-10 jonahwilliams@google.com Make ImageShader implement Shader for web ui (flutter/engine#12161) 2019-09-10 bkonyi@google.com Roll src/third_party/dart 2e8d912848..ccb6ba948b (30 commits) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e5c47936b17..b88894c8811b (3 commits) (flutter/engine#12151) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1bf30ce852e0..9e5c47936b17 (2 commits) (flutter/engine#12129) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8cae1e95a23b..1bf30ce852e0 (2 commits) (flutter/engine#12106) 2019-09-10 skia-flutter-autoroll@skia.org Roll fuchsia/clang/mac-amd64 from H1Qjc... to HfPKR... (flutter/engine#12088) 2019-09-10 chinmaygarde@google.com Don't launch the observatory by default on each embedder unit-test invocation. (flutter/engine#12087) 2019-09-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia c2d84bfa7421..8cae1e95a23b (4 commits) (flutter/engine#12086) 2019-09-10 bkonyi@google.com Roll src/third_party/dart fb14babf59..2e8d912848 (65 commits) 2019-09-10 chinmaygarde@google.com Guard availability of user notification related methods to iOS 10.0 (flutter/engine#12084) 2019-09-09 bmparr@google.com Add capability to add AppDelegate as UNUserNotificationCenterDelegate (flutter/engine#9864) ...

Smooth out iOS irregular input events delivery

645bc2b

Fixes flutter/flutter#31086 This patch is a lower level implementation of flutter/flutter#36616 that would only impact iOS engine, and host unittests.

googlebot added the cla: yes label Sep 1, 2019

Fix licenses

538309d

liyuqian force-pushed the iphonex_fix branch 2 times, most recently from b53f6a5 to 1df541d Compare September 3, 2019 05:58

Fix windows compile error

b1909cb

liyuqian force-pushed the iphonex_fix branch from 1df541d to b1909cb Compare September 3, 2019 16:39

liyuqian requested review from Hixie, chinmaygarde, goderbauer and nathanrogersgoogle and removed request for nathanrogersgoogle September 3, 2019 16:56

chinmaygarde suggested changes Sep 3, 2019

View reviewed changes

chinmaygarde reviewed Sep 3, 2019

View reviewed changes

liyuqian added 2 commits September 4, 2019 11:15

Move logic to pointer_data_dispatcher.h/cc

f6d6f9f

And let the PlatforView decide which PointerDataDispatcher is used.

Move test utility to input_events_unittests.cc

aaa6521

liyuqian force-pushed the iphonex_fix branch 2 times, most recently from a010efd to c432601 Compare September 4, 2019 19:40

Fix for MSVC, licenses, and format

60c5a00

liyuqian force-pushed the iphonex_fix branch from c432601 to 60c5a00 Compare September 4, 2019 19:41

Fix SchedulerPhase problem

21064e9

chinmaygarde reviewed Sep 7, 2019

View reviewed changes

More improvements

d90c49f

liyuqian commented Sep 8, 2019

View reviewed changes

chinmaygarde approved these changes Sep 9, 2019

View reviewed changes

More fixes

656ac24

liyuqian commented Sep 9, 2019

View reviewed changes

liyuqian merged commit b569e8c into flutter:master Sep 10, 2019

engine-flutter-autoroll mentioned this pull request Sep 11, 2019

Roll engine 7ea9884ab00e..6c46a173e3c1 (62 commits) flutter/flutter#40270

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2019

b569e8c Smooth out iOS irregular input events delivery (flutter/engin…

42013d2

…e#11817)

engine-flutter-autoroll mentioned this pull request Sep 11, 2019

Roll engine 7ea9884ab00e..6c46a173e3c1 (62 commits) flutter/flutter#40272

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2019

b569e8c Smooth out iOS irregular input events delivery (flutter/engin…

a5eefb2

…e#11817)

engine-flutter-autoroll mentioned this pull request Sep 11, 2019

Roll engine 7ea9884ab00e..6c46a173e3c1 (62 commits) flutter/flutter#40274

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2019

b569e8c Smooth out iOS irregular input events delivery (flutter/engin…

239791f

…e#11817)

engine-flutter-autoroll mentioned this pull request Sep 11, 2019

Roll engine 7ea9884ab00e..5b94c8ae84d0 (64 commits) flutter/flutter#40286

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 11, 2019

b569e8c Smooth out iOS irregular input events delivery (flutter/engin…

a44a0de

…e#11817)

engine-flutter-autoroll mentioned this pull request Sep 12, 2019

Roll engine 7ea9884ab00e..bbb1f124671b (69 commits) flutter/flutter#40315

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 12, 2019

b569e8c Smooth out iOS irregular input events delivery (flutter/engin…

21ac975

…e#11817)

mklim pushed a commit that referenced this pull request Sep 12, 2019

Revert "Smooth out iOS irregular input events delivery (#11817)" (#12251

3c6383f

) This reverts commit b569e8c.

liyuqian added a commit to liyuqian/engine that referenced this pull request Sep 13, 2019

Revert "Revert "Smooth out iOS irregular input events delivery (flutt…

3cb5ce3

…er#11817)" (flutter#12251)" This reverts commit 3c6383f.

liyuqian added a commit to liyuqian/engine that referenced this pull request Sep 20, 2019

Revert "Reland "Smooth out iOS irregular input events delivery (flutt…

004faef

…er#11817)" (flutter#12280)" This reverts commit aac33d1.

liyuqian added a commit that referenced this pull request Sep 20, 2019

Revert "Reland "Smooth out iOS irregular input events delivery (#11817)…

c2879ca

…" (#12280)" (#12364) This reverts commit aac33d1. Reason: flutter/flutter#40863 TBR: chinmaygarde, iskakaushik

liyuqian deleted the iphonex_fix branch September 24, 2019 00:14


		using Generator = std::function<int(int)>;

		// Simulate n input events where the i-th one is delivered at

Smooth out iOS irregular input events delivery #11817

Smooth out iOS irregular input events delivery #11817

Uh oh!

Conversation

liyuqian commented Sep 1, 2019

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Sep 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Sep 3, 2019

Uh oh!

liyuqian commented Sep 4, 2019

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liyuqian left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

chinmaygarde Sep 3, 2019 •

edited

Loading