Skip to content

Remove fluter tool usage of protobuf #40410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 2 commits into from
Sep 13, 2019
Merged

Remove fluter tool usage of protobuf #40410

jonahwilliams merged 2 commits into from
Sep 13, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 13, 2019

Description

It looks protobuf is going to have some upcoming breaking changes. I don't want to deal with these, so instead I'll just switch back to JSON.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 13, 2019
@codecov
Copy link

codecov bot commented Sep 13, 2019 •
edited
Loading

Codecov Report

Merging #40410 into master will increase coverage by 0.01%.
The diff coverage is 87.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40410      +/-   ##
==========================================
+ Coverage   59.59%    59.6%   +0.01%     
==========================================
  Files         192      191       -1     
  Lines       18602    18572      -30     
==========================================
- Hits        11086    11070      -16     
+ Misses       7516     7502      -14
Flag Coverage Δ
#flutter_tool 59.6% <87.09%> (+0.01%) ⬆️
Impacted Files Coverage Δ
...lutter_tools/lib/src/commands/update_packages.dart 3.63% <ø> (ø) ⬆️
...er_tools/lib/src/build_system/file_hash_store.dart 90.32% <87.09%> (-2.37%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.99% <0%> (-1.9%) ⬇️
packages/flutter_tools/lib/src/cache.dart 43.5% <0%> (-0.73%) ⬇️
packages/flutter_tools/lib/src/commands/run.dart 64.03% <0%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cfdbd...59827e2. Read the comment docs.

@jonahwilliams jonahwilliams changed the title Remove direct usage of protoc directly Remove fluter tool usage of protobuf Sep 13, 2019
zanderso
zanderso approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ question

packages/flutter_tools/pubspec.yaml
yaml: 2.1.16
flutter_goldens_client:
path: ../flutter_goldens_client
protobuf: 0.13.15
Copy link
Member

@zanderso zanderso Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need to be removed from the BUILD.gn?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We technically still depend on this transitively...I'm not sure. I'd rather leave it in to be safe

@jonahwilliams jonahwilliams merged commit 6ba8fa9 into flutter:master Sep 13, 2019
@jonahwilliams jonahwilliams deleted the remove_protoc branch September 13, 2019 19:49
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Remove direct flutter tool usage of protobuf for encoding file caches (…
7a5e60f 
…flutter#40410)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @zanderso @googlebot @fluttergithubbot