Skip to content

Ensure we find dart.exe on local engines #41514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Sep 28, 2019
Merged

Ensure we find dart.exe on local engines #41514

jonahwilliams merged 1 commit into from
Sep 28, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 27, 2019

Description

When performing a build with assemble we take the hash of the dart executable as an input. On windows, the executable is called dart.exe and not dart. While the cache engine artifacts were updated to account for this, the local engine artifacts never were.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 27, 2019
franciscojma86
franciscojma86 approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@franciscojma86 franciscojma86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #41514 into master will increase coverage by 1.55%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41514      +/-   ##
==========================================
+ Coverage   58.94%   60.49%   +1.55%     
==========================================
  Files         193      193              
  Lines       18833    18834       +1     
==========================================
+ Hits        11101    11394     +293     
+ Misses       7732     7440     -292
Flag Coverage Δ
#flutter_tool 60.49% <85.71%> (+1.55%) ⬆️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/artifacts.dart 70% <85.71%> (+0.79%) ⬆️
packages/flutter_tools/lib/src/mdns_discovery.dart 8.06% <0%> (-62.91%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.9% <0%> (-1.43%) ⬇️
packages/flutter_tools/lib/src/cache.dart 45.31% <0%> (-0.67%) ⬇️
packages/flutter_tools/lib/src/commands/run.dart 64.39% <0%> (-0.49%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 40.89% <0%> (+0.33%) ⬆️
...r_tools/lib/src/runner/flutter_command_runner.dart 73.1% <0%> (+0.42%) ⬆️
packages/flutter_tools/lib/src/devfs.dart 68.81% <0%> (+0.49%) ⬆️
packages/flutter_tools/lib/src/base/utils.dart 95.5% <0%> (+0.5%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d8918...5ad8efc. Read the comment docs.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Sep 28, 2019

The failure is a known flake that was already reverted

@jonahwilliams jonahwilliams merged commit 7a487b2 into flutter:master Sep 28, 2019
@jonahwilliams jonahwilliams deleted the dart_exe_local_engine branch September 28, 2019 01:54
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Ensure we find dart.exe on local engines (flutter#41514)
ceb9283
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@franciscojma86 franciscojma86 franciscojma86 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @franciscojma86 @googlebot @fluttergithubbot