use IOOverrides to allow inject file system, write test, find bug #40066
Conversation
Codecov Report
@@ Coverage Diff @@
## master #40066 +/- ##
=========================================
+ Coverage 55.61% 58.11% +2.5%
=========================================
Files 194 194
Lines 18726 18784 +58
=========================================
+ Hits 10414 10917 +503
+ Misses 8312 7867 -445
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #40066 +/- ##
=========================================
Coverage ? 58.34%
=========================================
Files ? 194
Lines ? 18784
Branches ? 0
=========================================
Hits ? 10959
Misses ? 7825
Partials ? 0
Continue to review full report at Codecov.
|
| WebSocketException, | ||
| WebSocketTransformer; | ||
|
|
||
| /// An [IOOverrides] that can delegate to [FileSystem] implementation if provided. |
There was a problem hiding this comment.
It looks like this is only used for testing. Should it go somewhere under test/src?
There was a problem hiding this comment.
Moved to test/src/io.dart
| AssetId('foobar', 'lib/main.dart'), | ||
| ])); | ||
| }, FlutterIOOverrides(fileSystem: fs)); | ||
| }), skip: Platform.isWindows); |
There was a problem hiding this comment.
Can you give an example of the normalization that is expected, or how this fails on Windows? We should try to track this down to avoid similar problems later.
There was a problem hiding this comment.
Added a comment describing the issue
Description
This allows testing code that uses or otherwise requires
dart:io, like build_runner and Glob. I used this new feature to write a test, and promptly found a bug in an asset reader that I wrote.It looks like build_runner relies on an implementation in dart:io to normalize file paths, so this test doesn't currently work on windows.