Skip to content

Reland "Measure iOS CPU/GPU percentage (#41234)" #41426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liyuqian merged 2 commits into from
Sep 28, 2019
Merged

Reland "Measure iOS CPU/GPU percentage (#41234)" #41426

liyuqian merged 2 commits into from
Sep 28, 2019

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Sep 27, 2019

This reverts commit f1e7fe8.

This fix is in flutter/packages#39

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 27, 2019
@liyuqian liyuqian changed the title Reland cpu gpu Reland "Measure iOS CPU/GPU percentage (#41234)" Sep 27, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #41426 into master will decrease coverage by 1.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41426      +/-   ##
==========================================
- Coverage   60.12%      59%   -1.13%     
==========================================
  Files         193      193              
  Lines       18832    18749      -83     
==========================================
- Hits        11323    11063     -260     
- Misses       7509     7686     +177
Flag Coverage Δ
#flutter_tool 59% <0%> (-1.13%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/base/net.dart 0% <0%> (-86.96%) ⬇️
...kages/flutter_tools/lib/src/web/web_validator.dart 0% <0%> (-75%) ⬇️
...ages/flutter_tools/lib/src/commands/build_aar.dart 30% <0%> (-63.34%) ⬇️
...ackages/flutter_tools/lib/src/commands/doctor.dart 28.57% <0%> (-35.72%) ⬇️
...s/flutter_tools/lib/src/test/flutter_platform.dart 0.55% <0%> (-27.5%) ⬇️
...ckages/flutter_tools/lib/src/commands/devices.dart 53.84% <0%> (-23.08%) ⬇️
packages/flutter_tools/lib/src/base/common.dart 72.72% <0%> (-18.19%) ⬇️
...r_tools/lib/src/runner/flutter_command_runner.dart 57.98% <0%> (-15.13%) ⬇️
packages/flutter_tools/lib/src/version.dart 81.9% <0%> (-11.43%) ⬇️
...ackages/flutter_tools/lib/src/reporting/usage.dart 78.66% <0%> (-10.67%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a66ea4f...9bd6b3a. Read the comment docs.

goderbauer
goderbauer approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian liyuqian merged commit 67b5bdf into flutter:master Sep 28, 2019
liyuqian added a commit that referenced this pull request Sep 29, 2019
@liyuqian
Revert "Reland "Measure iOS CPU/GPU percentage (#41234)" (#41426)"
868382a 
This reverts commit 67b5bdf.
@liyuqian liyuqian mentioned this pull request Sep 29, 2019
Merged
liyuqian added a commit that referenced this pull request Sep 29, 2019
@liyuqian
Revert "Reland "Measure iOS CPU/GPU percentage (#41234)" (#41426)" (#…
baea9bf 
…41575)

This reverts commit 67b5bdf.

Reason: it broke device lab.

TBR: @goderbauer
@liyuqian liyuqian deleted the reland_cpu_gpu branch September 29, 2019 18:23
liyuqian added a commit to liyuqian/flutter that referenced this pull request Sep 29, 2019
@liyuqian
Reland "Measure iOS CPU/GPU percentage flutter#41426"
738628f 
This reverts commit baea9bf.
liyuqian added a commit that referenced this pull request Sep 29, 2019
@liyuqian
Reland "Measure iOS CPU/GPU percentage #41426" (#41578)
9cc29c6 
This reverts commit baea9bf.

Additionally,   we let the test run on mac8 with iphonexs because the test won't run on Xcode 10.1 (mac3-7). Hence we force it to run on mac8 which currently has Xcode 10.2.
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@liyuqian @Inconnu08
Reland "Measure iOS CPU/GPU percentage (flutter#41234)" (flutter#41426)
37a6576 
This reverts commit f1e7fe8.

This fix is in flutter/packages#39
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@liyuqian @Inconnu08
Revert "Reland "Measure iOS CPU/GPU percentage (flutter#41234)" (flut…
fc6c874 
…ter#41426)" (flutter#41575)

This reverts commit 67b5bdf.

Reason: it broke device lab.

TBR: @goderbauer
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@liyuqian @Inconnu08
Reland "Measure iOS CPU/GPU percentage flutter#41426" (flutter#41578)
11119ad 
This reverts commit baea9bf.

Additionally,   we let the test run on mac8 with iphonexs because the test won't run on Xcode 10.1 (mac3-7). Hence we force it to run on mac8 which currently has Xcode 10.2.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liyuqian @goderbauer @googlebot @fluttergithubbot