Skip to content

Conversation

@liyuqian
Copy link
Contributor

This reverts commit 652be88.

This fix is in flutter/packages#37

@fluttergithubbot fluttergithubbot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 24, 2019
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to rev up the version for package:gauge somewhere to pick up the fix?

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyuqian
Copy link
Contributor Author

@goderbauer : good catch! I was actually just googling how to do it. Added the version to 703ea94 :)

@liyuqian liyuqian merged commit 406b449 into flutter:master Sep 26, 2019
jonahwilliams pushed a commit that referenced this pull request Sep 26, 2019
@liyuqian liyuqian deleted the reland_cpu_gpu branch September 27, 2019 00:15
liyuqian added a commit to liyuqian/flutter that referenced this pull request Sep 27, 2019
liyuqian added a commit that referenced this pull request Sep 28, 2019
liyuqian added a commit that referenced this pull request Sep 29, 2019
liyuqian added a commit that referenced this pull request Sep 29, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants