Fix downloading #37
Merged
Fix downloading #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Sep 24, 2019
packages/gauge/CHANGELOG.md
Outdated
Member
There was a problem hiding this comment.
Add "rename package to gauge" if it was already released under its old name?
Member
There was a problem hiding this comment.
nit: add a trailing comma after container(...) and format it like the other expects below.
Contributor
Author
There was a problem hiding this comment.
Sorry, the initial patch was full of irrelevant changes due to local branching error... I've now cleaned up the patch, and added a unit test.
This would fix our device lab failure. I didn't catch this mitake locally because I already downloaded the resources...
16403cc to
6de0453
Compare
Member
|
Can you add a test that would have failed without the await? To make sure we never regress this? |
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Sep 24, 2019
This reverts commit 652be88. This fix is in flutter/packages#37
liyuqian
added a commit
to flutter/flutter
that referenced
this pull request
Sep 26, 2019
This reverts commit 652be88. This fix is in flutter/packages#37
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
This reverts commit 652be88. This fix is in flutter/packages#37
stuartmorgan-g
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Reduce precision to save binary size * assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would fix our device lab failure.
I didn't catch this mitake locally because I already downloaded the
resources...