Skip to content

Don't update last compiled time when compilation is rejected #41424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Sep 27, 2019
Merged

Don't update last compiled time when compilation is rejected #41424

jonahwilliams merged 1 commit into from
Sep 27, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 26, 2019

Description

If we reject the compilation, keep the source files invalidated until they are updated. This keeps the error if the user repeatedly recompiles with an exception

Fixes #41399

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #41424 into master will decrease coverage by 0.57%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41424      +/-   ##
==========================================
- Coverage   60.12%   59.54%   -0.58%     
==========================================
  Files         193      193              
  Lines       18832    18832              
==========================================
- Hits        11323    11214     -109     
- Misses       7509     7618     +109
Flag Coverage Δ
#flutter_tool 59.54% <100%> (-0.58%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/devfs.dart 68.81% <100%> (ø) ⬆️
...ools/lib/src/build_runner/resident_web_runner.dart 35.25% <0%> (-45.52%) ⬇️
packages/flutter_tools/lib/src/base/logger.dart 45.62% <0%> (-36.89%) ⬇️
packages/flutter_tools/lib/src/features.dart 69.56% <0%> (-15.22%) ⬇️
...ckages/flutter_tools/lib/src/flutter_manifest.dart 79.36% <0%> (-5.83%) ⬇️
...ackages/flutter_tools/lib/src/commands/create.dart 67.97% <0%> (-5.23%) ⬇️
packages/flutter_tools/lib/src/context_runner.dart 70.17% <0%> (-1.76%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.9% <0%> (-1.43%) ⬇️
...ackages/flutter_tools/lib/src/resident_runner.dart 56.05% <0%> (-1.24%) ⬇️
packages/flutter_tools/lib/src/doctor.dart 74.09% <0%> (-1.12%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd2ba2...ddd7789. Read the comment docs.

@jonahwilliams jonahwilliams merged commit d7a8dda into flutter:master Sep 27, 2019
@jonahwilliams jonahwilliams deleted the no_update_failure branch September 27, 2019 17:33
jonahwilliams pushed a commit that referenced this pull request Sep 27, 2019
Revert "Dont update last compiled time when compilation is rejected (#…
99b8dac 
…41424)"

This reverts commit d7a8dda.
@jonahwilliams jonahwilliams mentioned this pull request Sep 27, 2019
Merged
jonahwilliams pushed a commit that referenced this pull request Sep 27, 2019
Revert "Dont update last compiled time when compilation is rejected (#…
d968b7c 
…41424)" (#41515)
@jonahwilliams jonahwilliams restored the no_update_failure branch September 29, 2019 18:54
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Dont update last compiled time when compilation is rejected (flutter#…
d33f9ea 
…41424)
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Revert "Dont update last compiled time when compilation is rejected (f…
6831bfc 
…lutter#41424)" (flutter#41515)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure that compilation errors don't update last compiled time

4 participants

@jonahwilliams @zanderso @googlebot @fluttergithubbot