add host and port to run configuration for web devices #40191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40191 +/- ##
=========================================
- Coverage 59.32% 59.03% -0.3%
=========================================
Files 192 192
Lines 18543 18551 +8
=========================================
- Hits 11001 10951 -50
- Misses 7542 7600 +58
Continue to review full report at Codecov.
|
Contributor
Author
|
@nturgut could you try this out locally and confirm that it works for yoou? |
yjbanov
approved these changes
Sep 12, 2019
|
|
||
| /// Retrieve the [DebugConnection] for the current application. | ||
| /// | ||
| /// if [useExtension] is true, will attempt to connect via the extension |
Contributor
There was a problem hiding this comment.
Also, are you sure "useExtension" is a thing? I don't see any other occurrences of it in this file 🤔
Contributor
Author
There was a problem hiding this comment.
..right, I removed it... silly me
zanderso
reviewed
Sep 12, 2019
| } | ||
|
|
||
| void usesWebOptions({ bool hide = true }) { | ||
| argParser.addOption('hostname', |
Member
There was a problem hiding this comment.
How about --web-hostname and --web-port ?
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow configuration of the hostname and port number chosen for running the web devices, via
--hostnameand--port. if not specified, they default tolocalhostand an arbitrary free os port by default.