Skip to content

Missing trailing commas #41473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a14n merged 3 commits into from
Sep 30, 2019
Merged

Missing trailing commas #41473

a14n merged 3 commits into from
Sep 30, 2019

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Sep 27, 2019

Description

add missing trailing commas (in packages/flutter/ and packages/flutter_tools/)

Related Issues

None

Tests

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@fluttergithubbot fluttergithubbot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 27, 2019
@a14n a14n added c: contributor-productivity Team-specific productivity, code health, technical debt. and removed a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Sep 27, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #41473 into master will increase coverage by 1.81%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41473      +/-   ##
==========================================
+ Coverage   58.84%   60.66%   +1.81%     
==========================================
  Files         193      193              
  Lines       18847    18846       -1     
==========================================
+ Hits        11090    11432     +342     
+ Misses       7757     7414     -343
Flag Coverage Δ
#flutter_tool 60.66% <54.54%> (+1.81%) ⬆️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/cache.dart 45.31% <ø> (+0.22%) ⬆️
packages/flutter_tools/lib/src/commands/test.dart 19.6% <ø> (ø) ⬆️
...ages/flutter_tools/lib/src/macos/macos_device.dart 62% <ø> (ø) ⬆️
...ter_tools/lib/src/build_system/targets/assets.dart 64% <ø> (ø) ⬆️
...tools/lib/src/windows/visual_studio_validator.dart 93.54% <ø> (ø) ⬆️
...utter_tools/lib/src/build_system/targets/dart.dart 50% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/asset.dart 85.65% <ø> (ø) ⬆️
packages/flutter_tools/lib/src/device.dart 61.4% <ø> (+1.75%) ⬆️
packages/flutter_tools/lib/src/run_hot.dart 68.47% <ø> (ø) ⬆️
...utter_tools/lib/src/build_runner/build_script.dart 19.09% <ø> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839fdbd...97ac329. Read the comment docs.

@a14n a14n force-pushed the missing-trailing-commas branch from 074a974 to a0960b4 Compare September 28, 2019 15:22
@a14n a14n force-pushed the missing-trailing-commas branch from a0960b4 to 97ac329 Compare September 30, 2019 07:57
goderbauer
goderbauer approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a14n a14n merged commit f0553ba into flutter:master Sep 30, 2019
@a14n a14n deleted the missing-trailing-commas branch September 30, 2019 16:48
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@a14n @Inconnu08
Missing trailing commas (flutter#41473)
9751ac8 
* add missing trailing commas

* add more missing trailing commas

* add more and more missing trailing commas
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@a14n @goderbauer @googlebot @fluttergithubbot