Skip to content

Roll build runner #41499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 4 commits into from
Sep 29, 2019
Merged

Roll build runner #41499

jonahwilliams merged 4 commits into from
Sep 29, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 27, 2019 •
edited
Loading

Description

Update build_runner versions and turn on incremental compiler.

Fixes #41490

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 27, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 27, 2019
@codecov
Copy link

codecov bot commented Sep 28, 2019 •
edited
Loading

Codecov Report

Merging #41499 into master will decrease coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #41499     +/-   ##
=========================================
- Coverage   60.41%   59.52%   -0.9%     
=========================================
  Files         193      193             
  Lines       18844    18844             
=========================================
- Hits        11385    11217    -168     
- Misses       7459     7627    +168
Flag Coverage Δ
#flutter_tool 59.52% <ø> (-0.9%) ⬇️
Impacted Files Coverage Δ
...utter_tools/lib/src/build_runner/build_runner.dart 0% <ø> (ø) ⬆️
...utter_tools/lib/src/build_runner/build_script.dart 19.09% <ø> (ø) ⬆️
...lutter_tools/lib/src/commands/update_packages.dart 3.68% <ø> (ø) ⬆️
...s/flutter_tools/lib/src/windows/msbuild_utils.dart 0% <0%> (-100%) ⬇️
...s/flutter_tools/lib/src/windows/build_windows.dart 0% <0%> (-85.37%) ⬇️
packages/flutter_tools/lib/src/emulator.dart 9.32% <0%> (-60.17%) ⬇️
.../flutter_tools/lib/src/commands/build_windows.dart 25% <0%> (-60%) ⬇️
...lutter_tools/lib/src/android/android_emulator.dart 20.83% <0%> (-45.84%) ⬇️
...kages/flutter_tools/lib/src/ios/ios_emulators.dart 8.69% <0%> (-39.14%) ⬇️
...ckages/flutter_tools/lib/src/commands/devices.dart 53.84% <0%> (-23.08%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e5cf0...3a0306e. Read the comment docs.

christopherfujino
christopherfujino approved these changes Sep 29, 2019
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jonahwilliams jonahwilliams merged commit 69af9ad into flutter:master Sep 29, 2019
@jonahwilliams jonahwilliams deleted the roll_build_runner branch September 29, 2019 20:01
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Update minimum build_runner version and enable incremental builder (f…
22e6b20 
…lutter#41499)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

@jakemac53 jakemac53 Awaiting requested review from jakemac53

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update build_runner to use dep pruning and incremental compiler

4 participants

@jonahwilliams @fluttergithubbot @christopherfujino @googlebot