Skip to content

rename port to web-port and hostname to web-hostname #40370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Sep 12, 2019
Merged

rename port to web-port and hostname to web-hostname #40370

jonahwilliams merged 1 commit into from
Sep 12, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 12, 2019

Description

To clarify that these are for the web category of devices.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 12, 2019
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 12, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@codecov
Copy link

codecov bot commented Sep 12, 2019 •
edited
Loading

Codecov Report

Merging #40370 into master will increase coverage by 0.54%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40370      +/-   ##
==========================================
+ Coverage   58.44%   58.98%   +0.54%     
==========================================
  Files         192      192              
  Lines       18627    18627              
==========================================
+ Hits        10886    10988     +102     
+ Misses       7741     7639     -102
Flag Coverage Δ
#flutter_tool 58.98% <100%> (+0.54%) ⬆️
Impacted Files Coverage Δ
.../flutter_tools/lib/src/runner/flutter_command.dart 80.95% <100%> (+0.43%) ⬆️
packages/flutter_tools/lib/src/commands/run.dart 64.03% <100%> (+0.49%) ⬆️
...ackages/flutter_tools/lib/src/macos/cocoapods.dart 35.77% <0%> (-50.46%) ⬇️
...s/flutter_tools/lib/src/commands/build_bundle.dart 86.79% <0%> (-11.33%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.99% <0%> (-1.9%) ⬇️
packages/flutter_tools/lib/src/build_info.dart 73.77% <0%> (-1.64%) ⬇️
packages/flutter_tools/lib/src/project.dart 82.53% <0%> (-1.27%) ⬇️
packages/flutter_tools/lib/src/cache.dart 43.5% <0%> (-0.73%) ⬇️
packages/flutter_tools/lib/src/plugins.dart 77.52% <0%> (-0.57%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 37.12% <0%> (-0.31%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd84cea...d7e328a. Read the comment docs.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Sep 12, 2019

I gave writing a unit test the a decent effort, however that ended up pulling a thread in the run_test.dart which required a significant level of mocking.

zanderso
zanderso approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@jonahwilliams jonahwilliams merged commit 1667d0c into flutter:master Sep 12, 2019
@jonahwilliams jonahwilliams deleted the web_ports branch September 12, 2019 22:25
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
rename port to web-port and hostname to web-hostname (flutter#40370)
6cb9ed7
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonahwilliams @fluttergithubbot @zanderso @googlebot