Skip to content

[flutter_tool] Add analytics events for ios-mdns fallback success/failure #41482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zanderso merged 1 commit into from
Sep 27, 2019
Merged

[flutter_tool] Add analytics events for ios-mdns fallback success/failure #41482

zanderso merged 1 commit into from
Sep 27, 2019

Conversation

@zanderso
Copy link
Member

@zanderso zanderso commented Sep 27, 2019

Description

Adds success/failure events for observatory discovery after an mdns failure on iOS.

Related Issues

#41085

Tests

I added the following tests:

Tests in devices_test.dart

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@zanderso zanderso added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 27, 2019
tvolkert
tvolkert approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherfujino
christopherfujino approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #41482 into master will decrease coverage by 0.62%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41482      +/-   ##
==========================================
- Coverage   60.53%   59.91%   -0.63%     
==========================================
  Files         193      193              
  Lines       18831    18833       +2     
==========================================
- Hits        11399    11283     -116     
- Misses       7432     7550     +118
Flag Coverage Δ
#flutter_tool 59.91% <75%> (-0.63%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/ios/devices.dart 65.97% <75%> (+0.28%) ⬆️
...tter_tools/lib/src/build_system/targets/linux.dart 5.55% <0%> (-88.89%) ⬇️
packages/flutter_tools/lib/src/cache.dart 22.32% <0%> (-23.67%) ⬇️
.../flutter_tools/lib/src/windows/windows_device.dart 42.62% <0%> (-8.2%) ⬇️
...s/flutter_tools/lib/src/commands/analyze_base.dart 4% <0%> (-8%) ⬇️
packages/flutter_tools/lib/src/artifacts.dart 64.01% <0%> (-5.2%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.9% <0%> (-1.43%) ⬇️
packages/flutter_tools/lib/src/base/logger.dart 82.12% <0%> (-0.39%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 40.89% <0%> (+0.16%) ⬆️
packages/flutter_tools/lib/src/device.dart 61.4% <0%> (+20.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17feb84...59ab2a1. Read the comment docs.

jonahwilliams
jonahwilliams approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso merged commit feaaa5d into flutter:master Sep 27, 2019
@zanderso zanderso deleted the more-ios-observatory-analytics branch September 27, 2019 19:19
@tvolkert tvolkert mentioned this pull request Sep 27, 2019
Merged
tvolkert added a commit that referenced this pull request Sep 27, 2019
@tvolkert
V1.9.1 hotfixes (#41504)
cc949a8 
* [flutter_tools] Report iOS mDNS lookup failures to analytics (#41384)
* [flutter_tools] Adds tests of mdns analytics events (#41410)
* [flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482)
* roll ideviceinstaller, libimobiledevice, libplist, openssl & usbmuxd to signed versions (#41411)
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@zanderso @Inconnu08
[flutter_tool] Add analytics events for ios-mdns fallback success/fai…
e8820a5 
…lure (flutter#41482)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@tvolkert tvolkert tvolkert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zanderso @christopherfujino @jonahwilliams @tvolkert @googlebot