Skip to content

V1.9.1 hotfixes #41504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvolkert merged 4 commits into from
Sep 27, 2019
Merged

V1.9.1 hotfixes #41504

tvolkert merged 4 commits into from
Sep 27, 2019

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Sep 27, 2019

roll ideviceinstaller, libimobiledevice, libplist, openssl & usbmuxd to signed versions (#41411)
[flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482)
[flutter_tools] Adds tests of mdns analytics events (#41410)
[flutter_tools] Report iOS mDNS lookup failures to analytics (#41384)

@fluttergithubbot fluttergithubbot changed the base branch from v1.9.1-hotfixes to master September 27, 2019 19:39
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 27, 2019

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to v1.9.1-hotfixes. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master. The circumstances where this is valid are very rare.

/cc @dnfield

@fluttergithubbot fluttergithubbot added engine flutter/engine related. See also e: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 27, 2019
@tvolkert tvolkert changed the base branch from master to v1.9.1-hotfixes September 27, 2019 19:39
@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 27, 2019

testing it manually...

@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #41504 into v1.9.1-hotfixes will increase coverage by 0.23%.
The diff coverage is 83.33%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           v1.9.1-hotfixes   #41504      +/-   ##
===================================================
+ Coverage            55.33%   55.57%   +0.23%     
===================================================
  Files                  196      196              
  Lines                18277    18281       +4     
===================================================
+ Hits                 10114    10160      +46     
+ Misses                8163     8121      -42
Flag Coverage Δ
#flutter_tool 55.57% <83.33%> (+0.23%) ⬆️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/ios/devices.dart 61.96% <83.33%> (+0.6%) ⬆️
...s/flutter_tools/lib/src/tester/flutter_tester.dart 13.4% <0%> (-57.74%) ⬇️
packages/flutter_tools/lib/src/base/net.dart 36.95% <0%> (-50%) ⬇️
packages/flutter_tools/lib/src/bundle.dart 31.81% <0%> (-43.94%) ⬇️
packages/flutter_tools/lib/src/base/common.dart 72.72% <0%> (-18.19%) ⬇️
...lib/src/build_runner/web_compilation_delegate.dart 0% <0%> (-14.68%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.73% <0%> (-1.47%) ⬇️
packages/flutter_tools/lib/src/base/terminal.dart 69.23% <0%> (-1.1%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 37.3% <0%> (-0.16%) ⬇️
packages/flutter_tools/lib/src/base/logger.dart 82.44% <0%> (+0.38%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a72edc2...d9a9dd8. Read the comment docs.

@christopherfujino
Copy link
Contributor

christopherfujino commented Sep 27, 2019

Works on my machine, would like to see @timsneath confirm that it works before merging to beta...

christopherfujino
christopherfujino approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert tvolkert merged commit cc949a8 into flutter:v1.9.1-hotfixes Sep 27, 2019
@tvolkert tvolkert deleted the v1.9.1-hotfixes branch September 27, 2019 22:05
@jmagman jmagman mentioned this pull request Nov 13, 2019
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tvolkert @fluttergithubbot @christopherfujino @zanderso @googlebot