Skip to content

Reland: Exit resident web runner on compilation failure #41505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 2 commits into from
Sep 28, 2019
Merged

Reland: Exit resident web runner on compilation failure #41505

jonahwilliams merged 2 commits into from
Sep 28, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 27, 2019

Description

Reland of #41441

We weren't tracking the initial compilation state, so an initial error would leave the app stuck. Instead we should exit and display the error.

ensure we cancel the first subscription stream to avoid state errors on the completer.

Fixes #41433

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 27, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #41505 into master will decrease coverage by 0.19%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #41505     +/-   ##
=========================================
- Coverage   60.67%   60.47%   -0.2%     
=========================================
  Files         193      193             
  Lines       18833    18842      +9     
=========================================
- Hits        11426    11394     -32     
- Misses       7407     7448     +41
Flag Coverage Δ
#flutter_tool 60.47% <92.85%> (-0.2%) ⬇️
Impacted Files Coverage Δ
...ools/lib/src/build_runner/resident_web_runner.dart 81.81% <ø> (+1.04%) ⬆️
...ges/flutter_tools/lib/src/build_runner/web_fs.dart 29.32% <92.85%> (+4.32%) ⬆️
...ackages/flutter_tools/lib/src/resident_runner.dart 47.84% <0%> (-9.45%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.9% <0%> (-1.43%) ⬇️
packages/flutter_tools/lib/src/cache.dart 45.31% <0%> (-0.67%) ⬇️
packages/flutter_tools/lib/src/ios/devices.dart 65.69% <0%> (-0.29%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 40.72% <0%> (-0.17%) ⬇️
...ackages/flutter_tools/lib/src/commands/unpack.dart 5.05% <0%> (ø) ⬆️
...utter_tools/lib/src/test/flutter_web_platform.dart 0% <0%> (ø) ⬆️
packages/flutter_tools/lib/src/devfs.dart 68.81% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update feaaa5d...b68a394. Read the comment docs.

@jonahwilliams jonahwilliams merged commit 07e5cf0 into flutter:master Sep 28, 2019
@jonahwilliams jonahwilliams deleted the exit_on_failure branch September 28, 2019 01:55
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Reland: Exit resident web runner on compilation failure (flutter#41505)
819a345
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web]: flutter run freezes after building with a syntax error

4 participants

@jonahwilliams @yjbanov @googlebot @fluttergithubbot