Skip to content

Exit resident web runner on compilation failure #41441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Sep 27, 2019
Merged

Exit resident web runner on compilation failure #41441

jonahwilliams merged 1 commit into from
Sep 27, 2019

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 27, 2019

Description

We weren't tracking the initial compilation state, so an initial error would leave the app stuck. Instead we should exit and display the error.

Fixes #41433

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 27, 2019
@jonahwilliams jonahwilliams added platform-web Web applications specifically and removed cla: yes labels Sep 27, 2019
@codecov
Copy link

codecov bot commented Sep 27, 2019 •
edited
Loading

Codecov Report

Merging #41441 into master will decrease coverage by 0.38%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41441      +/-   ##
==========================================
- Coverage      60%   59.62%   -0.39%     
==========================================
  Files         193      193              
  Lines       18832    18840       +8     
==========================================
- Hits        11301    11233      -68     
- Misses       7531     7607      +76
Flag Coverage Δ
#flutter_tool 59.62% <91.66%> (-0.39%) ⬇️
Impacted Files Coverage Δ
...ools/lib/src/build_runner/resident_web_runner.dart 81.81% <ø> (+1.04%) ⬆️
...ges/flutter_tools/lib/src/build_runner/web_fs.dart 28.64% <91.66%> (+3.64%) ⬆️
packages/flutter_tools/lib/src/android/gradle.dart 44.04% <0%> (-31.76%) ⬇️
packages/flutter_tools/lib/src/macos/xcode.dart 36.66% <0%> (-25%) ⬇️
packages/flutter_tools/lib/src/template.dart 95.23% <0%> (-4.77%) ⬇️
packages/flutter_tools/lib/src/asset.dart 82.27% <0%> (-3.38%) ⬇️
packages/flutter_tools/lib/src/base/os.dart 26.98% <0%> (-3.18%) ⬇️
packages/flutter_tools/lib/src/build_info.dart 75.13% <0%> (-1.63%) ⬇️
packages/flutter_tools/lib/src/version.dart 91.9% <0%> (-1.43%) ⬇️
packages/flutter_tools/lib/src/cache.dart 45.31% <0%> (-0.67%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07056b...9951a52. Read the comment docs.

@jonahwilliams jonahwilliams merged commit a1852a1 into flutter:master Sep 27, 2019
@jonahwilliams jonahwilliams deleted the exit_on_failure branch September 27, 2019 17:32
jonahwilliams pushed a commit that referenced this pull request Sep 27, 2019
Revert "Exit resident web runner on initial compilation failure (#41441…
15575c6 
…)"

This reverts commit a1852a1.
@jonahwilliams jonahwilliams mentioned this pull request Sep 27, 2019
Merged
jonahwilliams pushed a commit that referenced this pull request Sep 27, 2019
Revert "Exit resident web runner on initial compilation failure (#41441…
618fac9 
…)" (#41498)
@jonahwilliams jonahwilliams restored the exit_on_failure branch September 27, 2019 19:01
@jonahwilliams jonahwilliams mentioned this pull request Sep 27, 2019
Merged
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Exit resident web runner on initial compilation failure (flutter#41441)
907f81a
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@Inconnu08
Revert "Exit resident web runner on initial compilation failure (flut…
040d17d 
…ter#41441)" (flutter#41498)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees

No one assigned

Labels

platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web]: flutter run freezes after building with a syntax error

4 participants

@jonahwilliams @yjbanov @googlebot @fluttergithubbot