ensure dart2js does not compile unsupported packages #40368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
approved these changes
Sep 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #40368 +/- ##
==========================================
+ Coverage 58.44% 59.29% +0.84%
==========================================
Files 192 192
Lines 18627 18549 -78
==========================================
+ Hits 10886 10998 +112
+ Misses 7741 7551 -190
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #40368 +/- ##
==========================================
+ Coverage 58.44% 59.29% +0.84%
==========================================
Files 192 192
Lines 18627 18549 -78
==========================================
+ Hits 10886 10998 +112
+ Misses 7741 7551 -190
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We currently throw when debug compiling an application to JavaScript if it imports an unsupported library, but not in release mode. This change aligns the behavior to avoid work arounds.