a11y improvements for textfield #40390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (!isFocused && label != null) { | ||
| visitor(label); | ||
|
|
||
| if (isFocused) { |
Contributor
There was a problem hiding this comment.
I'm not quite sure if it is any better, but it feels like these if statements could be re-arranged.
"Always add the label. Add the hint if it is focused, otherwise add the hint if there is no label."
if (label != null) {
visitor(label);
}
if (hint != null) {
if (isFocused) {
visitor(hint);
} else if (label == null) {
visitor(hint)
}
}
Member
Author
There was a problem hiding this comment.
That looks cleaner. Changed.
jonahwilliams
approved these changes
Sep 12, 2019
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
with nit on ifs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An unfocused text field should add the label to the semantics tree. If no label is given, use the hint. A focused text field should include the label followed by the hint.
Related Issues
#38940
#39918
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?