Skip to content

Remove dead accessors of _getUnusedChangesInLastReload. #39837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rmacnak-google merged 1 commit into from
Sep 12, 2019
Merged

Remove dead accessors of _getUnusedChangesInLastReload. #39837

rmacnak-google merged 1 commit into from
Sep 12, 2019

Conversation

@rmacnak-google
Copy link
Contributor

@rmacnak-google rmacnak-google commented Sep 4, 2019 •
edited
Loading

This was part of a disused tool to explain what did and did not run after reload.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 4, 2019

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 4, 2019
@codecov
Copy link

codecov bot commented Sep 4, 2019 •
edited
Loading

Codecov Report

Merging #39837 into master will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39837      +/-   ##
==========================================
- Coverage   57.33%   56.81%   -0.53%     
==========================================
  Files         194      194              
  Lines       18691    18646      -45     
==========================================
- Hits        10716    10593     -123     
- Misses       7975     8053      +78
Flag Coverage Δ
#flutter_tool 56.81% <ø> (-0.53%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/vmservice.dart 39.29% <ø> (+2.13%) ⬆️
...ackages/flutter_tools/lib/src/resident_runner.dart 56.21% <ø> (+1.23%) ⬆️
...s/flutter_tools/lib/src/windows/msbuild_utils.dart 0% <0%> (-100%) ⬇️
...s/flutter_tools/lib/src/windows/build_windows.dart 0% <0%> (-85%) ⬇️
...lutter_tools/lib/src/build_system/targets/ios.dart 4.25% <0%> (-74.47%) ⬇️
.../flutter_tools/lib/src/commands/build_windows.dart 25% <0%> (-60%) ⬇️
packages/flutter_tools/lib/src/web/chrome.dart 9.09% <0%> (-42.43%) ⬇️
.../flutter_tools/lib/src/android/android_studio.dart 13.74% <0%> (-36.26%) ⬇️
...utter_tools/lib/src/build_system/targets/dart.dart 51.56% <0%> (-25%) ⬇️
packages/flutter_tools/lib/src/macos/xcode.dart 50% <0%> (-7.15%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9f210...260547f. Read the comment docs.

@rmacnak-google rmacnak-google marked this pull request as ready for review September 5, 2019 01:04
jonahwilliams
jonahwilliams approved these changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please add a brief description in the PR comment for future archaeologists.

@jonahwilliams jonahwilliams added waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds and removed waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds labels Sep 12, 2019
@rmacnak-google rmacnak-google merged commit a6138bb into flutter:master Sep 12, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Sep 30, 2019
@rmacnak-google @Inconnu08
Remove dead accessors of _getUnusedChangesInLastReload. (flutter#39837)
247ad1a 
This was part of a disused tool to explain what did and did not run after reload.
@rmacnak-google rmacnak-google deleted the _getUnusedChangesInLastReload branch October 15, 2019 17:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rmacnak-google @fluttergithubbot @jonahwilliams @googlebot