Exception when selecting in TextField #41326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
approved these changes
Sep 25, 2019
| final _ToolbarParentData childParentData = child.parentData; | ||
|
|
||
| final Offset localTopCenter = globalToLocal(Offset(_arrowTipX, _barTopY)); | ||
| final Offset topCenter = Offset(_arrowTipX, _barTopY); |
Contributor
There was a problem hiding this comment.
nit: localTopCenter was created so _arrowTipX and _barTopY can be converted to local coordinates. Now that it's no longer needed, removing the variable all together might make the code more readable.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Sep 30, 2019
This was referenced Oct 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an app with nested Navigators, selecting text in a TextField caused an exception to be logged.
This PR fixes it by removing the offending call to
globalToLocal, which turns out to be unnecessary. The coordinates relative to the selection menu are always equivalent to global coordinates, because the selection menu is in an Overlay covering the entire screen. Even in situations where the containing Navigator does not cover the full screen, the Overlay still does.Related Issues
Closes #37046
Tests
I added the following tests: