This repository was archived by the owner on Sep 30, 2024. It is now read-only.
auth: Remove redirects to session package#64260
Merged
Merged
Conversation
This was referenced Aug 4, 2024
This was referenced Aug 4, 2024
Member
Author
This was referenced Aug 4, 2024
d883c8d to
dfbf707
Compare
0d8db85 to
167bb74
Compare
dfbf707 to
0e00bb5
Compare
167bb74 to
d30dfd4
Compare
0e00bb5 to
6e2f9b3
Compare
d30dfd4 to
4851fee
Compare
pjlast
approved these changes
Aug 7, 2024
6e2f9b3 to
be555d1
Compare
4851fee to
567c425
Compare
Member
Author
These functions are not required to be called outside of frontend, so there's no need to reexport them. Instead, we consolidate the signout cookie logic in the session package. Test plan: Just moved some code around, go compiler doesn't complain.
567c425 to
6288634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are not required to be called outside of frontend, so there's no need to reexport them. Instead, we consolidate the signout cookie logic in the session package.
Test plan: Just moved some code around, go compiler doesn't complain.