Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Make return type more obvious#63651

Merged
eseliger merged 2 commits into
mainfrom
es/07-04-choremakereturntypemoreobvious
Jul 31, 2024
Merged

chore: Make return type more obvious#63651
eseliger merged 2 commits into
mainfrom
es/07-04-choremakereturntypemoreobvious

Conversation

@eseliger

@eseliger eseliger commented Jul 4, 2024

Copy link
Copy Markdown
Member

These functions return StoreOpts, but that wasn't immediately clear, so adding this small tweak here.

Test plan: Ci passes.

This was referenced Jul 4, 2024
Merged
Merged
Merged
@cla-bot cla-bot Bot added the cla-signed label Jul 4, 2024
This was referenced Jul 4, 2024
Merged
Merged
Merged
Merged
Merged
@eseliger Graphite App

eseliger commented Jul 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jul 4, 2024
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from ab27718 to a5da203 Compare July 4, 2024 20:29
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from dfdef28 to 98725d3 Compare July 4, 2024 20:29
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from a5da203 to 3755fa8 Compare July 5, 2024 05:16
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from 98725d3 to fc0a5d6 Compare July 5, 2024 05:16
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from 3755fa8 to 8a67674 Compare July 5, 2024 07:37
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from fc0a5d6 to 213e738 Compare July 5, 2024 07:37
@eseliger eseliger mentioned this pull request Jul 5, 2024
Merged
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from 8a67674 to 678e359 Compare July 5, 2024 11:28
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from 213e738 to d5de478 Compare July 5, 2024 11:28
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from 678e359 to 33e4ce3 Compare July 9, 2024 22:37
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from d5de478 to 664a50b Compare July 9, 2024 22:37
@github-actions

github-actions Bot commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from 33e4ce3 to ba8087e Compare July 9, 2024 23:27
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from 664a50b to a12d5c5 Compare July 9, 2024 23:28
@github-actions

github-actions Bot commented Jul 9, 2024

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from ba8087e to 27ad141 Compare July 9, 2024 23:58
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from a12d5c5 to 767aea3 Compare July 9, 2024 23:59
@github-actions

github-actions Bot commented Jul 10, 2024

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@eseliger eseliger requested a review from a team July 29, 2024 21:55
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from e612cdb to fdd0c1a Compare July 30, 2024 00:47
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from 15618ef to 9e9cc88 Compare July 30, 2024 00:47
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from fdd0c1a to 6fc53cc Compare July 30, 2024 17:21
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from 9e9cc88 to a787518 Compare July 30, 2024 17:21
This was referenced Jul 30, 2024
Merged
Merged
Merged
Merged
Merged
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from 6fc53cc to 936d4a1 Compare July 30, 2024 23:25
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from a787518 to 85a7ac7 Compare July 30, 2024 23:26
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from 936d4a1 to d942e03 Compare July 31, 2024 01:01
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from 85a7ac7 to 157554a Compare July 31, 2024 01:02
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from d942e03 to 5e8e24f Compare July 31, 2024 01:17
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from 157554a to 08318c6 Compare July 31, 2024 01:17
@eseliger
subrepo: More explicitly define supported hosts
f450628 
This takes less hoops to find what we support, and we don't extend this any time soon.

Test plan:

CI passes.
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from 5e8e24f to f450628 Compare July 31, 2024 01:34
@eseliger
chore: Make return type more obvious
695a4c3 
These functions return StoreOpts, but that wasn't immediately clear, so adding this small tweak here.

Test plan: Ci passes.
@eseliger eseliger force-pushed the es/07-04-choremakereturntypemoreobvious branch from 08318c6 to 695a4c3 Compare July 31, 2024 01:34
@eseliger eseliger force-pushed the es/07-04-subrepomoreexplicitlydefinesupportedhosts branch from f450628 to d87f95c Compare July 31, 2024 01:36
Base automatically changed from es/07-04-subrepomoreexplicitlydefinesupportedhosts to main July 31, 2024 01:41
@eseliger eseliger merged commit b89ed0f into main Jul 31, 2024
@eseliger eseliger deleted the es/07-04-choremakereturntypemoreobvious branch July 31, 2024 01:42
This was referenced Aug 4, 2024
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@michaellzc michaellzc michaellzc approved these changes

@camdencheek camdencheek camdencheek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eseliger @michaellzc @camdencheek