These functions return StoreOpts, but that wasn't immediately clear, so adding this small tweak here.

Test plan: Ci passes.

This code was using a strange pattern that isn't actually observed or controlled by our worker mechanisms, so switching it to return proper goroutines.

Test plan:

CI passes, would like a thorough review on the licensecheck code.

Since we don't do the enterprise/oss split anymore, this global package is no longer required and we can move the code to where it's actually used.

Test plan: Go compiler doesn't complain, and integration tests are still passing.

This doesn't blow up, but golangci-lint complains about it so following best practices here.

Test plan: Go test still passes, linter doesn't complain anymore.

This validation was done in the azure oauth provider, which mixes two completely separate domains.

Test plan: CI, code review.

This removes the need to register a global URL watcher. Instead, the conf package now returns a cached version, and also makes a copy of it so it's impossible to accidentally modify it.

This makes it safe in non-cmd/frontend packages to use this.

Test plan: All tests are still passing.

… provider

Just a little cleanup which makes the main function a bit shorter and easier to understand that userpasswd is not different to other authn providers.

Test plan: Authn with builtin still works in CI integration tests.

This current code sets a global variable which couples the session package and the app package and the session package cannot work when the NewHandler method wasn't called yet.

This also used to wait for redis implicitly, without any indication of doing that.

To be more explicit about that, we now do that in the main function of frontend instead, and create the session store where required on the fly.

Test plan: Login still works, integration/E2E tests are passing.