This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Deglobalize oneclickexporter instance#64066
Merged
eseliger merged 2 commits intoJul 31, 2024
Merged
Conversation
This was referenced Jul 25, 2024
This was referenced Jul 25, 2024
Member
Author
This was referenced Jul 25, 2024
470d14e to
d6f3d80
Compare
cfa904d to
664f5ff
Compare
d6f3d80 to
a9f0181
Compare
664f5ff to
1400487
Compare
5c3e6ac to
bb44d97
Compare
a39e99a to
38cb8c7
Compare
bb44d97 to
1bbd102
Compare
38cb8c7 to
629d722
Compare
1bbd102 to
04b9992
Compare
629d722 to
60064c7
Compare
This was referenced Jul 30, 2024
04b9992 to
da9e4f2
Compare
60064c7 to
0a236d8
Compare
da9e4f2 to
6faccbb
Compare
0a236d8 to
ff67a28
Compare
6faccbb to
309a5fe
Compare
ff67a28 to
c2014dd
Compare
309a5fe to
3ab612b
Compare
c2014dd to
8bbc42e
Compare
Only frontend uses this package, so moving this package here to make clearer what service depends on this code. This package also requires a call to the Init() func which only frontend does right now, so this also was a footgun where someone might start using this package outside of frontend, but then it's not correctly initialized. Test plan: Just moved a package, go compiler doesn't complain.
This PR removes the requirement that a global variable is initialized in the frontend main function. Instead, we create a data exporter where it's used. Test plan: CI passes, code review.
3ab612b to
306b6ad
Compare
8bbc42e to
f29430e
Compare
Base automatically changed from
es/07-25-choremoveinternalhighlighttocmdfrontend
to
main
July 31, 2024 02:34
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement that a global variable is initialized in the frontend main function. Instead, we create a data exporter where it's used.
Test plan: CI passes, code review.