This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Cleanup more cross-cmd imports#64259
Merged
Merged
Conversation
This was referenced Aug 4, 2024
This was referenced Aug 4, 2024
Member
Author
72e7002 to
d883c8d
Compare
This was referenced Aug 4, 2024
evict
approved these changes
Aug 5, 2024
kritzcreek
previously requested changes
Aug 5, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes to block merge, didn't take a look at the full change yet.
antonsviridov-src
approved these changes
Aug 5, 2024
7380af5 to
f90f1cf
Compare
d883c8d to
dfbf707
Compare
f90f1cf to
55a484c
Compare
dfbf707 to
0e00bb5
Compare
Contributor
|
Caution License checking failed, please read: how to deal with third parties licensing. |
55a484c to
c2de048
Compare
0e00bb5 to
6e2f9b3
Compare
This PR makes the calls to create the OIDC provider explicit, so that we don't need to implicitly need to call a Refresh method, even if we might end up not needing the `p.oidc`. This is a start toward being able to create providers on the fly cheaply vs having a globally managed list of providers in memory. Test plan: Auth with SAMS locally still works.
This PR fixes a few more imports from /internal/ packages using /cmd/... contents. Test plan: Mainly moved code around and CI still passes.
c2de048 to
a4166e9
Compare
6e2f9b3 to
be555d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few more imports from /internal/ packages using /cmd/... contents.
Test plan: Mainly moved code around and CI still passes.