This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Remove cmd/frontend/external/app#64054
Merged
Merged
Conversation
This was referenced Jul 24, 2024
Member
Author
This was referenced Jul 24, 2024
821a005 to
b7751cd
Compare
e23e5da to
47c65cb
Compare
b7751cd to
b0a716b
Compare
47c65cb to
8fdf541
Compare
This was referenced Jul 25, 2024
b0a716b to
4b281f8
Compare
4b281f8 to
37a5a9a
Compare
8508aa2 to
a2664ca
Compare
pjlast
approved these changes
Jul 30, 2024
37a5a9a to
54fc5d9
Compare
a2664ca to
3c8691a
Compare
This was referenced Jul 30, 2024
54fc5d9 to
3bbe7ab
Compare
3c8691a to
6fed73c
Compare
3bbe7ab to
5887fd4
Compare
6fed73c to
3abe7a2
Compare
5887fd4 to
c9308f9
Compare
3abe7a2 to
c94b5a8
Compare
This takes less hoops to find what we support, and we don't extend this any time soon. Test plan: CI passes.
These functions return StoreOpts, but that wasn't immediately clear, so adding this small tweak here. Test plan: Ci passes.
This code was using a strange pattern that isn't actually observed or controlled by our worker mechanisms, so switching it to return proper goroutines. Test plan: CI passes, would like a thorough review on the licensecheck code.
c9308f9 to
f374563
Compare
Since we don't do the enterprise/oss split anymore, this global package is no longer required and we can move the code to where it's actually used. Test plan: Go compiler doesn't complain, and integration tests are still passing.
c94b5a8 to
1aa841e
Compare
Base automatically changed from
es/07-05-licensecheckmakepropergoroutine
to
main
July 31, 2024 01:42
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't do the enterprise/oss split anymore, this global package is no longer required and we can move the code to where it's actually used.
Test plan: Go compiler doesn't complain, and integration tests are still passing.