This repository was archived by the owner on Sep 30, 2024. It is now read-only.
frontend: Consolidate remaining registry packages#64156
Merged
eseliger merged 2 commits intoAug 5, 2024
Conversation
This was referenced Jul 30, 2024
Member
Author
This was referenced Jul 30, 2024
715b71f to
07e6005
Compare
93f5a2a to
024dedd
Compare
664ae32 to
1f08b60
Compare
024dedd to
bcaadb8
Compare
1f08b60 to
1d63d4c
Compare
bcaadb8 to
46cc5ff
Compare
1d63d4c to
5ca2c0b
Compare
46cc5ff to
921d2c9
Compare
5ca2c0b to
b9d0696
Compare
921d2c9 to
c33a1de
Compare
b9d0696 to
338a8d2
Compare
c33a1de to
fbf1b3a
Compare
To make things more explicit and remove the global variable, this is now passed down to where it's needed. It is a bit messy right now, since it's used deep in the serve-handler but that just highlights better where it's actually used IMO. As a next step, I want to get rid of the requirement to indicate server-restart required, so we should be able to drop a bunch of the prop drilling here. Test plan: Still compiles, E2E test works.
This PR simplifies and consolidates the remaining parts of the various registry packages, and moves everything under cmd/frontend/internal for better encapusation. This also removes the need to _ import packages which feels very brittle. Test plan: Go compiler doesn't complain about moved code.
338a8d2 to
4ac2192
Compare
fbf1b3a to
af18139
Compare
This was referenced Aug 4, 2024
evict
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies and consolidates the remaining parts of the various registry packages, and moves everything under cmd/frontend/internal for better encapusation.
This also removes the need to _ import packages which feels very brittle.
Test plan: Go compiler doesn't complain about moved code.