This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: remove cmd/frontend/external redirection package#64070
Merged
eseliger merged 2 commits intoJul 31, 2024
Conversation
This was referenced Jul 25, 2024
Member
Author
79128b2 to
f1393a3
Compare
8f52067 to
8130ebc
Compare
f1393a3 to
566506f
Compare
8130ebc to
09aa64a
Compare
6cd9e24 to
8dc6d74
Compare
pjlast
approved these changes
Jul 30, 2024
c34fd46 to
88953d3
Compare
8dc6d74 to
294ed57
Compare
This was referenced Jul 30, 2024
88953d3 to
1422aa6
Compare
294ed57 to
5d84bc8
Compare
1422aa6 to
6644f6e
Compare
5d84bc8 to
b0f7915
Compare
6644f6e to
837bec7
Compare
b0f7915 to
ab53645
Compare
837bec7 to
1892ab0
Compare
ab53645 to
4e53a43
Compare
1892ab0 to
adebe47
Compare
4e53a43 to
184f24a
Compare
…lickexport This package is only used inside frontend, so no need to expose it publicly. Test plan: Just moved one folder, Go compiler doesn't complain.
This package is no longer required now that everything that depends on session is inside cmd/frontend. This removes one layer of indirection in the code nav flow. Test plan: Just removed aliases and pointed to the original code, and the Go compiler doesn't complain.
adebe47 to
5f8b437
Compare
184f24a to
283961d
Compare
Base automatically changed from
es/07-25-choremovecmdfrontendoneclickexporttocmdfrontendinternaloneclickexport
to
main
July 31, 2024 02:41
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is no longer required now that everything that depends on session is inside cmd/frontend. This removes one layer of indirection in the code nav flow.
Test plan: Just removed aliases and pointed to the original code, and the Go compiler doesn't complain.