This repository was archived by the owner on Sep 30, 2024. It is now read-only.
frontend: Remove global conf server variable#64155
Merged
Merged
Conversation
This was referenced Jul 30, 2024
Member
Author
This was referenced Jul 30, 2024
94bc2eb to
1ee0818
Compare
715b71f to
07e6005
Compare
1ee0818 to
6544b5e
Compare
07e6005 to
664ae32
Compare
6544b5e to
d25b98a
Compare
664ae32 to
1f08b60
Compare
d25b98a to
f853edc
Compare
1f08b60 to
1d63d4c
Compare
f853edc to
e680c47
Compare
1d63d4c to
5ca2c0b
Compare
e680c47 to
43783c6
Compare
5ca2c0b to
b9d0696
Compare
Base automatically changed from
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
to
main
July 31, 2024 02:42
b9d0696 to
338a8d2
Compare
To make things more explicit and remove the global variable, this is now passed down to where it's needed. It is a bit messy right now, since it's used deep in the serve-handler but that just highlights better where it's actually used IMO. As a next step, I want to get rid of the requirement to indicate server-restart required, so we should be able to drop a bunch of the prop drilling here. Test plan: Still compiles, E2E test works.
338a8d2 to
4ac2192
Compare
This was referenced Aug 4, 2024
evict
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make things more explicit and remove the global variable, this is now passed down to where it's needed.
It is a bit messy right now, since it's used deep in the serve-handler but that just highlights better where
it's actually used IMO. As a next step, I want to get rid of the requirement to indicate server-restart
required, so we should be able to drop a bunch of the prop drilling here.
Test plan: Still compiles, E2E test works.