This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Don't pass nil context#64055
Merged
Merged
Conversation
This was referenced Jul 24, 2024
Member
Author
This was referenced Jul 24, 2024
e23e5da to
47c65cb
Compare
6962471 to
497fe86
Compare
47c65cb to
8fdf541
Compare
497fe86 to
6680d2b
Compare
This was referenced Jul 25, 2024
8fdf541 to
8508aa2
Compare
camdencheek
approved these changes
Jul 29, 2024
8508aa2 to
a2664ca
Compare
a5fee6b to
347add9
Compare
a2664ca to
3c8691a
Compare
347add9 to
5f73f6f
Compare
This was referenced Jul 30, 2024
3c8691a to
6fed73c
Compare
5f73f6f to
1e78f5b
Compare
6fed73c to
3abe7a2
Compare
1e78f5b to
1967de5
Compare
3abe7a2 to
c94b5a8
Compare
1967de5 to
8452b34
Compare
This takes less hoops to find what we support, and we don't extend this any time soon. Test plan: CI passes.
These functions return StoreOpts, but that wasn't immediately clear, so adding this small tweak here. Test plan: Ci passes.
This code was using a strange pattern that isn't actually observed or controlled by our worker mechanisms, so switching it to return proper goroutines. Test plan: CI passes, would like a thorough review on the licensecheck code.
Since we don't do the enterprise/oss split anymore, this global package is no longer required and we can move the code to where it's actually used. Test plan: Go compiler doesn't complain, and integration tests are still passing.
c94b5a8 to
1aa841e
Compare
This doesn't blow up, but golangci-lint complains about it so following best practices here. Test plan: Go test still passes, linter doesn't complain anymore.
8452b34 to
df27e30
Compare
Base automatically changed from
es/07-25-choreremovecmdfrontendexternalapp
to
main
July 31, 2024 01:42
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't blow up, but golangci-lint complains about it so following best practices here.
Test plan: Go test still passes, linter doesn't complain anymore.