This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Simplify license routines#64068
Merged
Merged
Conversation
This was referenced Jul 25, 2024
This was referenced Jul 25, 2024
This was referenced Jul 25, 2024
Member
Author
This was referenced Jul 25, 2024
f857b21 to
290b34b
Compare
7c616d8 to
bb38578
Compare
290b34b to
2997b26
Compare
bb38578 to
a997e42
Compare
23d74dd to
263198f
Compare
pjlast
approved these changes
Jul 30, 2024
8d291a9 to
c0443d9
Compare
263198f to
d2d3f7f
Compare
This was referenced Jul 30, 2024
c0443d9 to
1f82819
Compare
d2d3f7f to
37398d8
Compare
1f82819 to
c954cc7
Compare
37398d8 to
fd23f9d
Compare
c954cc7 to
3590627
Compare
fd23f9d to
9cdfa5a
Compare
3590627 to
7fde91f
Compare
9cdfa5a to
9393d37
Compare
Only frontend uses this package, so moving this package here to make clearer what service depends on this code. This package also requires a call to the Init() func which only frontend does right now, so this also was a footgun where someone might start using this package outside of frontend, but then it's not correctly initialized. Test plan: Just moved a package, go compiler doesn't complain.
This PR removes the requirement that a global variable is initialized in the frontend main function. Instead, we create a data exporter where it's used. Test plan: CI passes, code review.
This package is not imported anywhere anymore, so we can safely drop it. Test plan: Go compiler doesn't complain after package was removed.
There's no need to track they haven't been called twice, this is a programming error and should not happen. We don't need to maintain a global int for that, IMO which just makes it harder to call in tests etc. Test plan: Local stack still works, code review.
7fde91f to
bc84228
Compare
9393d37 to
ef6f130
Compare
Base automatically changed from
es/07-25-choreremoveunusedloghandlerspackage
to
main
July 31, 2024 02:34
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no need to track they haven't been called twice, this is a programming error and should not happen. We don't need to maintain a global int for that, IMO which just makes it harder to call in tests etc.
Test plan: Local stack still works, code review.