Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Remove unnecessary _ imports#64158

Merged
eseliger merged 1 commit into
mainfrom
es/07-30-choreremoveunnecessary_imports
Aug 6, 2024
Merged

chore: Remove unnecessary _ imports#64158
eseliger merged 1 commit into
mainfrom
es/07-30-choreremoveunnecessary_imports

Conversation

@eseliger

@eseliger eseliger commented Jul 30, 2024

Copy link
Copy Markdown
Member

These imports don't seem to have side-effects so dropping them to keep the dependency graph simple.

Test plan: E2E CI still passes.

This was referenced Jul 30, 2024
Merged
Merged
Merged
@cla-bot cla-bot Bot added the cla-signed label Jul 30, 2024
This was referenced Jul 30, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@eseliger Graphite App

eseliger commented Jul 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

This was referenced Jul 30, 2024
Merged
Merged
Merged
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jul 30, 2024
@eseliger eseliger force-pushed the es/07-30-choremovecmdfrontendwebhookstocmdfrontendinternal branch from 617e49f to 37ab2e5 Compare July 30, 2024 23:52
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from 67d7ac0 to b2fc6ca Compare July 30, 2024 23:53
@eseliger eseliger force-pushed the es/07-30-choremovecmdfrontendwebhookstocmdfrontendinternal branch from 37ab2e5 to c4e8b45 Compare July 31, 2024 01:29
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from b2fc6ca to 0c19436 Compare July 31, 2024 01:30
@eseliger eseliger force-pushed the es/07-30-choremovecmdfrontendwebhookstocmdfrontendinternal branch from c4e8b45 to cdbbb62 Compare July 31, 2024 01:46
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from 0c19436 to e202d74 Compare July 31, 2024 01:47
@eseliger eseliger force-pushed the es/07-30-choremovecmdfrontendwebhookstocmdfrontendinternal branch from cdbbb62 to 5a69721 Compare July 31, 2024 02:25
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from e202d74 to 2877663 Compare July 31, 2024 02:25
@eseliger eseliger force-pushed the es/07-30-choremovecmdfrontendwebhookstocmdfrontendinternal branch from 5a69721 to a4f0f7b Compare July 31, 2024 02:35
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from 2877663 to 89ad79a Compare July 31, 2024 02:36
@eseliger eseliger force-pushed the es/07-30-choremovecmdfrontendwebhookstocmdfrontendinternal branch from a4f0f7b to a420cf6 Compare August 4, 2024 15:53
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from 89ad79a to 330db23 Compare August 4, 2024 15:53
@eseliger eseliger force-pushed the es/07-30-choremovecmdfrontendwebhookstocmdfrontendinternal branch from a420cf6 to caec90c Compare August 4, 2024 17:01
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from 330db23 to 6ab8518 Compare August 4, 2024 17:01
This was referenced Aug 4, 2024
Merged
Merged
Merged
Merged
@eseliger eseliger marked this pull request as ready for review August 5, 2024 10:14
@eseliger eseliger requested a review from a team August 5, 2024 10:14
@eseliger eseliger changed the base branch from es/07-30-choremovecmdfrontendwebhookstocmdfrontendinternal to graphite-base/64158 August 5, 2024 14:30
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from 6ab8518 to 8a7ab20 Compare August 5, 2024 14:47
@eseliger eseliger changed the base branch from graphite-base/64158 to main August 5, 2024 14:47
@eseliger
chore: Remove unnecessary _ imports
c9ba3ca 
These imports don't seem to have side-effects so dropping them to keep the dependency graph simple.

Test plan: E2E CI still passes.
@eseliger eseliger force-pushed the es/07-30-choreremoveunnecessary_imports branch from 8a7ab20 to c9ba3ca Compare August 6, 2024 10:50
@eseliger eseliger merged commit ff52b14 into main Aug 6, 2024
@eseliger eseliger deleted the es/07-30-choreremoveunnecessary_imports branch August 6, 2024 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pjlast pjlast pjlast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eseliger @pjlast