This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Remove redis init side-effect of app.NewHandler#64062
Merged
eseliger merged 1 commit intoJul 31, 2024
Conversation
This was referenced Jul 25, 2024
Member
Author
This was referenced Jul 25, 2024
This was referenced Jul 25, 2024
8583401 to
2fa3de9
Compare
b1a7039 to
8202eb9
Compare
2fa3de9 to
9455b62
Compare
4eb55b6 to
7865ff1
Compare
dc48948 to
f87df38
Compare
7865ff1 to
14845f5
Compare
f87df38 to
906f4ac
Compare
pjlast
approved these changes
Jul 30, 2024
14845f5 to
1f5cf02
Compare
906f4ac to
f0a1fa5
Compare
This was referenced Jul 30, 2024
1f5cf02 to
1a7b2e4
Compare
f0a1fa5 to
19ff47f
Compare
1a7b2e4 to
6f191d6
Compare
19ff47f to
7678f53
Compare
6f191d6 to
9d0d757
Compare
7678f53 to
0a608d3
Compare
9d0d757 to
c882243
Compare
0a608d3 to
a7e2c69
Compare
c882243 to
76e7780
Compare
Base automatically changed from
es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider
to
main
July 31, 2024 02:09
This current code sets a global variable which couples the session package and the app package and the session package cannot work when the NewHandler method wasn't called yet. This also used to wait for redis implicitly, without any indication of doing that. To be more explicit about that, we now do that in the main function of frontend instead, and create the session store where required on the fly. Test plan: Login still works, integration/E2E tests are passing.
a7e2c69 to
4676485
Compare
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This current code sets a global variable which couples the session package and the app package and the session package cannot work when the NewHandler method wasn't called yet.
This also used to wait for redis implicitly, without any indication of doing that.
To be more explicit about that, we now do that in the main function of frontend instead, and create the session store where required on the fly.
Test plan: Login still works, integration/E2E tests are passing.