This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Remove global externalURL watcher#64058
Merged
Merged
Conversation
This was referenced Jul 24, 2024
This was referenced Jul 24, 2024
Member
Author
affc579 to
90487b1
Compare
8989049 to
9acee90
Compare
90487b1 to
c7a5454
Compare
9acee90 to
2c8eefc
Compare
This was referenced Jul 25, 2024
c7a5454 to
2533b27
Compare
19f7a4e to
0505dfd
Compare
bc77455 to
5fb3e86
Compare
Contributor
|
Caution License checking failed, please read: how to deal with third parties licensing. |
This was referenced Jul 30, 2024
0505dfd to
c23518b
Compare
5fb3e86 to
3863570
Compare
c23518b to
c27ecf9
Compare
3863570 to
edcb05b
Compare
c27ecf9 to
48432a2
Compare
edcb05b to
cc245dd
Compare
This takes less hoops to find what we support, and we don't extend this any time soon. Test plan: CI passes.
These functions return StoreOpts, but that wasn't immediately clear, so adding this small tweak here. Test plan: Ci passes.
This code was using a strange pattern that isn't actually observed or controlled by our worker mechanisms, so switching it to return proper goroutines. Test plan: CI passes, would like a thorough review on the licensecheck code.
Since we don't do the enterprise/oss split anymore, this global package is no longer required and we can move the code to where it's actually used. Test plan: Go compiler doesn't complain, and integration tests are still passing.
This doesn't blow up, but golangci-lint complains about it so following best practices here. Test plan: Go test still passes, linter doesn't complain anymore.
This validation was done in the azure oauth provider, which mixes two completely separate domains. Test plan: CI, code review.
48432a2 to
1f5bb9d
Compare
This removes the need to register a global URL watcher. Instead, the conf package now returns a cached version, and also makes a copy of it so it's impossible to accidentally modify it. This makes it safe in non-cmd/frontend packages to use this. Test plan: All tests are still passing.
cc245dd to
2193422
Compare
Base automatically changed from
es/07-25-cleanupmoveazureopenaiproviderconfigvalidationtorightplace
to
main
July 31, 2024 01:43
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the need to register a global URL watcher. Instead, the conf package now returns a cached version, and also makes a copy of it so it's impossible to accidentally modify it.
This makes it safe in non-cmd/frontend packages to use this.
Test plan: All tests are still passing.