This repository was archived by the owner on Sep 30, 2024. It is now read-only.
licensecheck: Make proper goroutine#63655
Merged
Merged
Conversation
This was referenced Jul 5, 2024
Merged
Merged
Member
Author
213e738 to
d5de478
Compare
b54a2d6 to
21c1ab7
Compare
d5de478 to
664a50b
Compare
21c1ab7 to
d14364e
Compare
Contributor
|
Caution License checking failed, please read: how to deal with third parties licensing. |
664a50b to
a12d5c5
Compare
d14364e to
68a116a
Compare
Contributor
|
Caution License checking failed, please read: how to deal with third parties licensing. |
a12d5c5 to
767aea3
Compare
68a116a to
238d377
Compare
Contributor
|
Caution License checking failed, please read: how to deal with third parties licensing. |
767aea3 to
2765238
Compare
238d377 to
39dbdf5
Compare
Contributor
|
Caution License checking failed, please read: how to deal with third parties licensing. |
2765238 to
4572b10
Compare
39dbdf5 to
f9f896d
Compare
Contributor
|
Caution License checking failed, please read: how to deal with third parties licensing. |
15618ef to
9e9cc88
Compare
4b281f8 to
37a5a9a
Compare
9e9cc88 to
a787518
Compare
37a5a9a to
54fc5d9
Compare
This was referenced Jul 30, 2024
a787518 to
85a7ac7
Compare
54fc5d9 to
3bbe7ab
Compare
85a7ac7 to
157554a
Compare
3bbe7ab to
5887fd4
Compare
157554a to
08318c6
Compare
5887fd4 to
c9308f9
Compare
This takes less hoops to find what we support, and we don't extend this any time soon. Test plan: CI passes.
These functions return StoreOpts, but that wasn't immediately clear, so adding this small tweak here. Test plan: Ci passes.
08318c6 to
695a4c3
Compare
This code was using a strange pattern that isn't actually observed or controlled by our worker mechanisms, so switching it to return proper goroutines. Test plan: CI passes, would like a thorough review on the licensecheck code.
c9308f9 to
f374563
Compare
This was referenced Aug 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was using a strange pattern that isn't actually observed or controlled by our worker mechanisms, so switching it to return proper goroutines.
Test plan: CI passes, would like a thorough review on the licensecheck code.