This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Move cmd/frontend/webhooks to cmd/frontend/internal#64157
Merged
eseliger merged 1 commit intoAug 5, 2024
Conversation
This was referenced Jul 30, 2024
Member
Author
This was referenced Jul 30, 2024
93f5a2a to
024dedd
Compare
617e49f to
37ab2e5
Compare
024dedd to
bcaadb8
Compare
37ab2e5 to
c4e8b45
Compare
bcaadb8 to
46cc5ff
Compare
c4e8b45 to
cdbbb62
Compare
46cc5ff to
921d2c9
Compare
cdbbb62 to
5a69721
Compare
921d2c9 to
c33a1de
Compare
5a69721 to
a4f0f7b
Compare
c33a1de to
fbf1b3a
Compare
a4f0f7b to
a420cf6
Compare
fbf1b3a to
af18139
Compare
a420cf6 to
caec90c
Compare
This was referenced Aug 4, 2024
evict
approved these changes
Aug 5, 2024
Member
Author
Nothing outside frontend needs to import this package, to properly signify that we move it to internal where 90% of the other packages reside, and avoid ambiguity on "what service is running what code exactly". Test plan: Just moved a package, Go compiler doesn't complain.
caec90c to
ff205e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing outside frontend needs to import this package, to properly signify that we move it to internal where 90% of the other packages reside, and avoid ambiguity on "what service is running what code exactly".
Test plan: Just moved a package, Go compiler doesn't complain.