This repository was archived by the owner on Sep 30, 2024. It is now read-only.
oidc: Don't require to run refresh on provider init#64159
Merged
Conversation
This was referenced Jul 30, 2024
Member
Author
0c19436 to
e202d74
Compare
5583dd0 to
ac276f3
Compare
e202d74 to
2877663
Compare
ac276f3 to
5027a47
Compare
2877663 to
89ad79a
Compare
5027a47 to
9d452b8
Compare
89ad79a to
330db23
Compare
9d452b8 to
86a96cd
Compare
330db23 to
6ab8518
Compare
86a96cd to
7380af5
Compare
This was referenced Aug 4, 2024
6ab8518 to
8a7ab20
Compare
7380af5 to
f90f1cf
Compare
8a7ab20 to
c9ba3ca
Compare
f90f1cf to
55a484c
Compare
55a484c to
c2de048
Compare
pjlast
approved these changes
Aug 7, 2024
This PR makes the calls to create the OIDC provider explicit, so that we don't need to implicitly need to call a Refresh method, even if we might end up not needing the `p.oidc`. This is a start toward being able to create providers on the fly cheaply vs having a globally managed list of providers in memory. Test plan: Auth with SAMS locally still works.
c2de048 to
a4166e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the calls to create the OIDC provider explicit, so that we don't need to implicitly need to call a Refresh method, even if we might end up not needing the
p.oidc.This is a start toward being able to create providers on the fly cheaply vs having a globally managed list of providers in memory.
We did call refresh everywhere we do now anyways to the best of my understanding, so a passive goroutine in the background to my best understanding didn't add a lot here.
Test plan: Auth with SAMS locally still works.