Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore: Init userpasswd provider where we initialize every other authn provider#64061

Merged
eseliger merged 1 commit into
mainfrom
es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider
Jul 31, 2024
Merged

chore: Init userpasswd provider where we initialize every other authn provider#64061
eseliger merged 1 commit into
mainfrom
es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider

Conversation

@eseliger

@eseliger eseliger commented Jul 25, 2024

Copy link
Copy Markdown
Member

Just a little cleanup which makes the main function a bit shorter and easier to understand that userpasswd is not different to other authn providers.

Test plan: Authn with builtin still works in CI integration tests.

@cla-bot cla-bot Bot added the cla-signed label Jul 25, 2024
This was referenced Jul 25, 2024
Merged
Merged
Merged
Merged
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels Jul 25, 2024
This was referenced Jul 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
@eseliger Graphite App

eseliger commented Jul 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

This was referenced Jul 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from 2c8eefc to a21ba11 Compare July 28, 2024 14:45
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from b1a7039 to 8202eb9 Compare July 28, 2024 14:45
@eseliger eseliger marked this pull request as ready for review July 29, 2024 21:58
@eseliger eseliger requested a review from a team July 29, 2024 21:58
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from a21ba11 to 236a53b Compare July 29, 2024 23:00
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 4eba238 to 4eb55b6 Compare July 29, 2024 23:13
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from ead8701 to a5655e4 Compare July 29, 2024 23:35
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 4eb55b6 to 7865ff1 Compare July 29, 2024 23:36
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from a5655e4 to bc77455 Compare July 30, 2024 00:47
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 7865ff1 to 14845f5 Compare July 30, 2024 00:48
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from bc77455 to 5fb3e86 Compare July 30, 2024 17:22
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 14845f5 to 1f5cf02 Compare July 30, 2024 17:22
This was referenced Jul 30, 2024
Merged
Merged
Merged
Merged
Merged
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from 5fb3e86 to 3863570 Compare July 30, 2024 23:29
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 1f5cf02 to 1a7b2e4 Compare July 30, 2024 23:30
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from 3863570 to edcb05b Compare July 31, 2024 01:05
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 1a7b2e4 to 6f191d6 Compare July 31, 2024 01:06
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from edcb05b to cc245dd Compare July 31, 2024 01:20
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 6f191d6 to 9d0d757 Compare July 31, 2024 01:21
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from cc245dd to 2193422 Compare July 31, 2024 01:37
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 9d0d757 to c882243 Compare July 31, 2024 01:38
Base automatically changed from es/07-25-choreremoveglobalexternalurlwatcher to main July 31, 2024 01:43
@eseliger
chore: Init userpasswd provider where we initialize every other authn…
76e7780 
… provider

Just a little cleanup which makes the main function a bit shorter and easier to understand that userpasswd is not different to other authn providers.

Test plan: Authn with builtin still works in CI integration tests.
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from c882243 to 76e7780 Compare July 31, 2024 01:44
@eseliger eseliger merged commit 03c2907 into main Jul 31, 2024
@eseliger eseliger deleted the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch July 31, 2024 02:09
This was referenced Aug 4, 2024
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pjlast pjlast pjlast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eseliger @pjlast