Rebases and Resolves Review Feedback#3
Merged
lizan merged 113 commits intolizan:authn_policy_docfrom Nov 16, 2022
Merged
Conversation
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
fix: set correct listener context order Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com>
* provider: only store resource if spec has changed Leverage the metadata.Generation field to consider whether to update the newly reconciled resource into the watchable map which will trigger translations in the backend. Fixes: envoyproxy#407 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
No longer needed now that order is maintained by using a list, thanks to envoyproxy#535 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
* TLS Passthrough support This commit adds a tlsroute controller which is further used to configure tls passthrough in envoy. Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * Adding tlsroute experimental crd in testdata update gatewayclass/gateway/httproute experimental CRDs to use standard schemas Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * keep other testdata changes out of this PR Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * added testcases for tlsroutes, include serviceport in irInfraPortName Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * lintfix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * tlroute kubernetes provider test Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * added xds tls config validate test for passthrough Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * types test tlsroute Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * test fixes Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * xds config tests for tls passthrough Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * increase test coverage Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * testfix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * separate xds tls listener Signed-off-by: Shubham Chauhan <shubham@tetrate.io> testfix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * additional xds validate tests Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * tlsroute refgrant test Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * add rbac permissions for tlsroute Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * updates post rebase Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * add status updater, gateway watcher for tlsroute Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * add status update framework for tlsroute Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * lintfix, testfix, fix post rebase Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * yet another lintfix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * refactor tlslistener/route -> tcplistener/route, xds updates Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * missed a file Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * lintfix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * rebase, review comments Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * minor testfix Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * more Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * review comments, status deepcopy, check routes in ns Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * revert bad import, testfix, new test Signed-off-by: Shubham Chauhan <shubham@tetrate.io> * rev sort Signed-off-by: Shubham Chauhan <shubham@tetrate.io> Signed-off-by: Shubham Chauhan <shubham@tetrate.io>
* feat: implement liveness and readiness probes Signed-off-by: bitliu <bitliu@tencent.com> * fix: remove duplicate case Signed-off-by: bitliu <bitliu@tencent.com> * Fix merge conflicts Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
* chore: run conformance tests with identical ports Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
update example manifest apiversion Signed-off-by: AliceProxy <alicewasko@datawire.io>
* Updates ParentRef Status Conditions Signed-off-by: danehans <daneyonhansen@gmail.com> * Resolved @skriss 10-11-22 Feedback Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: bitliu <bitliu@tencent.com>
fix: remove deprecated set-output Signed-off-by: bitliu <bitliu@tencent.com>
Signed-off-by: Fredrik Geijer Haeggström <fredrik.g.haeggstrom@gmail.com>
* .gitignore: Ignore `vendor/` directories
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
* xds translator: Fix racy startup
If the watchable.Map has content in it already when .Subscribe() is called
on it, then those initial entries won't have a snapshot.Updates entry in
that first snapshot. For the first snapshot we just need to iterate over
snapshot.State.
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
* provider tests: Fix running the test multiple times
controller-runtime.SetupSignalHandler() panics if called more than once in
a process. So running the test multiple times (`go test -count=2`)
reliably causes the test to panic.
So don't use ctrl.SetupSignalHandler() in unit tests.
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
* Add and use a new watchutil.HandleSubscription function
As the added godoc comment says, "This is better than iterating over
snapshot.Updates because it handles the case where the the watchable.Map
already contains entries before .Subscribe is called."
The generalizes the fix that I made in the XDS translator.
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
* docs: Add a bit to watching.md about HandleSubscription
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
* Move HandleSubscription et al. around per Arko's feedback
I was going to do a type alias for `watchable.Update`, but:
internal/message/watchutil.go:7:6: generic type cannot be alias
So I just defined a new child type, which is fine because there aren't any
methods on Update.
Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
* infra: hash resources with long names Signed-off-by: AliceProxy <alicewasko@datawire.io> * add tests for hashing resources Signed-off-by: AliceProxy <alicewasko@datawire.io> * hashing: replace sha1 with sha256 Signed-off-by: AliceProxy <alicewasko@datawire.io> * hashing: only use 8 chars Signed-off-by: AliceProxy <alicewasko@datawire.io> * ir/infra: always hash resource names Signed-off-by: AliceProxy <alicewasko@datawire.io> * update all test manifests with hashed names Signed-off-by: AliceProxy <alicewasko@datawire.io> * only hash necessary resources Signed-off-by: AliceProxy <alicewasko@datawire.io> * update test manifests Signed-off-by: AliceProxy <alicewasko@datawire.io> Signed-off-by: AliceProxy <alicewasko@datawire.io>
* Adds Release Doc Signed-off-by: danehans <daneyonhansen@gmail.com> * Resolves Arko and Luke review feedback Signed-off-by: danehans <daneyonhansen@gmail.com> * Removes the step to link release notes Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
…nvoyproxy#580) * use RefNotPermitted reason for invalid cross-namespace TLS cert ref Closes envoyproxy#538. Signed-off-by: Steve Kriss <krisss@vmware.com>
* feat: support markdown resources Signed-off-by: bitliu <bitliu@tencent.com> * update Signed-off-by: bitliu <bitliu@tencent.com> Signed-off-by: bitliu <bitliu@tencent.com>
* Moves Changelogs to Release Notes Signed-off-by: danehans <daneyonhansen@gmail.com> * Adds release-artifacts target with release notes Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
* run conformance tests on three Kubernetes versions Closes envoyproxy#493. Signed-off-by: Steve Kriss <krisss@vmware.com> * serialize conformance runs on single runner Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: danehans <daneyonhansen@gmail.com> Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: danehans <daneyonhansen@gmail.com>
…oxy#685) * explain the non-transparent mode design decision for TCP/UDP Signed-off-by: zhaohuabing <zhaohuabing@gmail.com> Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com>
* add ir for udp route envoyproxy#641 Signed-off-by: zhaohuabing <zhaohuabing@gmail.com>
Signed-off-by: bitliu <bitliu@tencent.com>
feat: set envoy image to dev latest Signed-off-by: bitliu <bitliu@tencent.com>
* fix: incorrect level of envoy-gateway configmap Signed-off-by: bitliu <bitliu@tencent.com>
* translator: add accesslog Signed-off-by: hejianpeng <hejianpeng2@huawei.com>
* Update roadmap for v0.3.0 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Relates to envoyproxy#642 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
* xds translator for udp route Signed-off-by: zhaohuabing <zhaohuabing@gmail.com>
* had to also append the TLSRoute name to the listener to make it unique Fixes: envoyproxy#691 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Updates Readme Slack and Google Group Signed-off-by: danehans <daneyonhansen@gmail.com>
Relates to envoyproxy#642 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: danehans <daneyonhansen@gmail.com>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Co-authored-by: Arko Dasgupta <arkodg@users.noreply.github.com> Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: danehans <daneyonhansen@gmail.com>
22a6705 to
12f33db
Compare
Author
|
@lizan all changes other than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Rebases from main branch.
Signed-off-by: danehans daneyonhansen@gmail.com