Skip to content

feat: support markdown resources#571

Merged
danehans merged 2 commits intoenvoyproxy:mainfrom
Xunzhuo:feat-md-site
Oct 17, 2022
Merged

feat: support markdown resources#571
danehans merged 2 commits intoenvoyproxy:mainfrom
Xunzhuo:feat-md-site

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Oct 15, 2022

Added support for markdown.

Signed-off-by: bitliu bitliu@tencent.com

@Xunzhuo Xunzhuo requested a review from a team as a code owner October 15, 2022 04:33
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #571 (50e3e8d) into main (39456ca) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   60.63%   60.83%   +0.19%     
==========================================
  Files          46       46              
  Lines        5576     5576              
==========================================
+ Hits         3381     3392      +11     
+ Misses       1985     1977       -8     
+ Partials      210      207       -3     
Impacted Files Coverage Δ
internal/provider/kubernetes/gateway.go 50.65% <0.00%> (+1.52%) ⬆️
internal/provider/kubernetes/gatewayclass.go 73.18% <0.00%> (+2.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: bitliu <bitliu@tencent.com>
Copy link
Copy Markdown
Contributor

@danehans danehans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits throughout. Otherwise LGTM.

@danehans
Copy link
Copy Markdown
Contributor

cc: @kflynn

Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo requested a review from danehans October 16, 2022 02:52
@Xunzhuo
Copy link
Copy Markdown
Member Author

Xunzhuo commented Oct 16, 2022

Thanks for your comments, I have updated them all, and fixed the lint errors along with it. @danehans

Copy link
Copy Markdown
Contributor

@danehans danehans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This puts the docs for the v0.2.0 release in good shape. Thank you!

@danehans
Copy link
Copy Markdown
Contributor

cc: @kflynn

@danehans danehans merged commit 0cf2f87 into envoyproxy:main Oct 17, 2022
This was referenced Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants