Skip to content

chore: run conformance tests with identical ports#534

Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom
Xunzhuo:chore-identical-ports
Oct 11, 2022
Merged

chore: run conformance tests with identical ports#534
arkodg merged 3 commits intoenvoyproxy:mainfrom
Xunzhuo:chore-identical-ports

Conversation

@Xunzhuo
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo commented Oct 10, 2022

Resolve: #454

Run conformance tests with identical ports across gateways.

CONFORMANCE_UNIQUE_PORTS=false make run-conformance

Signed-off-by: bitliu bitliu@tencent.com

@Xunzhuo Xunzhuo requested a review from a team as a code owner October 10, 2022 06:16
Signed-off-by: bitliu <bitliu@tencent.com>
@Xunzhuo Xunzhuo force-pushed the chore-identical-ports branch from b75c1da to c860d5b Compare October 10, 2022 06:27
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 10, 2022

Codecov Report

Merging #534 (b1a2eb8) into main (3ed86df) will decrease coverage by 0.41%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
- Coverage   60.71%   60.30%   -0.42%     
==========================================
  Files          45       45              
  Lines        5582     5582              
==========================================
- Hits         3389     3366      -23     
- Misses       1989     2007      +18     
- Partials      204      209       +5     
Impacted Files Coverage Δ
internal/provider/kubernetes/tlsroute.go 53.70% <0.00%> (-9.73%) ⬇️
internal/provider/kubernetes/gateway.go 50.32% <0.00%> (-0.44%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danehans danehans added the area/ci CI and build related issues label Oct 10, 2022
@danehans danehans added this to the 0.2.0 milestone Oct 10, 2022
Signed-off-by: bitliu <bitliu@tencent.com>
arkodg
arkodg previously approved these changes Oct 11, 2022
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Signed-off-by: Arko Dasgupta <arkodg@users.noreply.github.com>
@arkodg arkodg merged commit 5801e0b into envoyproxy:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci CI and build related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Conformance Tests with Identical Listener ports across Gateways

4 participants