run conformance tests on three Kubernetes versions#681
run conformance tests on three Kubernetes versions#681arkodg merged 3 commits intoenvoyproxy:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #681 +/- ##
==========================================
- Coverage 63.63% 63.61% -0.03%
==========================================
Files 47 47
Lines 5766 5749 -17
==========================================
- Hits 3669 3657 -12
+ Misses 1873 1866 -7
- Partials 224 226 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Closes envoyproxy#493. Signed-off-by: Steve Kriss <krisss@vmware.com>
b976e81 to
2accddd
Compare
| verbose: true | ||
|
|
||
| conformance-tests: | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
we ideally want unit-tests, conformance and push to be on the same runner
There was a problem hiding this comment.
AFAIK there's no way to run steps within a job in parallel, hence splitting conformance out into its own matrix job so it's not too slow. We can use upload/download artifact steps to share the binaries between jobs (this is the gist of #683). Are there other reasons for wanting everything on the same runner?
There was a problem hiding this comment.
the only one is to make sure the same binary is used between all steps, so recommend
- running the jobs sequentially in this PR and then
- CI: use built image for conformance tests #683 can be used to enhance the CI to be able to share builds across runners
- can parallelize the matrix post that
Signed-off-by: Steve Kriss <krisss@vmware.com>
02e2042 to
fa7dd3a
Compare
Signed-off-by: Steve Kriss <krisss@vmware.com>
Closes #493.
Signed-off-by: Steve Kriss krisss@vmware.com