Skip to content

add ir for udp route#646

Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:udproute-ir
Nov 7, 2022
Merged

add ir for udp route#646
arkodg merged 2 commits intoenvoyproxy:mainfrom
zhaohuabing:udproute-ir

Conversation

@zhaohuabing
Copy link
Copy Markdown
Member

@zhaohuabing zhaohuabing commented Oct 26, 2022

Add ir for udp route #641
Signed-off-by: zhaohuabing zhaohuabing@gmail.com

Signed-off-by: zhaohuabing <zhaohuabing@gmail.com>
@zhaohuabing zhaohuabing requested a review from a team as a code owner October 26, 2022 04:02
@zhaohuabing zhaohuabing changed the title add ir for udp route #641 add ir for udp route Oct 26, 2022
Xunzhuo
Xunzhuo previously approved these changes Oct 26, 2022
Copy link
Copy Markdown
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@danehans danehans mentioned this pull request Oct 26, 2022
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Oct 26, 2022

apart from the TCP typo, looks good @zhaohuabing !
thanks for also adding the TCP Validate calls which was missed earlier :)

Signed-off-by: zhaohuabing <zhaohuabing@gmail.com>
@zhaohuabing
Copy link
Copy Markdown
Member Author

zhaohuabing commented Oct 27, 2022

For now, this IR and the incoming translator implementation consider EG as a non-transparent proxy between a UDP client and server, which means the server behinde the EG can't get the original source of UDP packages, instead, it sees the IP and port of the EG(Envoy).

@youngnick
Copy link
Copy Markdown
Contributor

Yeah, I'm sorry to be a blocker, but I think we need to write down a design for what UDP options we'll make available, with some explanation of the tradeoffs, before we go too much further here.

@danehans
Copy link
Copy Markdown
Contributor

I think we need to write down a design for what UDP options we'll make available, with some explanation of the tradeoffs..

@zhaohuabing do you mind creating a .md for this and submitting a separate PR?

@zhaohuabing
Copy link
Copy Markdown
Member Author

Okay, I'll do that.

@zhaohuabing
Copy link
Copy Markdown
Member Author

Okay, I'll do that.

#685

@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented Nov 7, 2022

thanks for adding the design doc with #685, imho this PR should be good to go

@arkodg arkodg merged commit 7c6c37a into envoyproxy:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants