use RefNotPermitted reason for invalid cross-namespace TLS cert ref #580
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom Oct 17, 2022
Merged
use RefNotPermitted reason for invalid cross-namespace TLS cert ref #580arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg merged 2 commits intoenvoyproxy:mainfrom
Conversation
Closes envoyproxy#538. Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
commented
Oct 17, 2022
Comment on lines
67
to
68
| /*tests.GatewaySecretMissingReferenceGrant, | ||
| tests.GatewaySecretInvalidReferenceGrant,*/ |
Contributor
Author
There was a problem hiding this comment.
These conformance tests will pass as long as they are not run after the previous two (GatewaySecretReferenceGrantAllInNamespace or GatewaySecretReferenceGrantSpecific). Once those two have been run, it requires an EG restart before the missing/invalid referencegrant tests will pass again. This smells like #539, so updated the comment here.
Alice-Lilith
approved these changes
Oct 17, 2022
arkodg
approved these changes
Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #538.
Signed-off-by: Steve Kriss krisss@vmware.com