Merged
Conversation
Alice-Lilith
previously approved these changes
Oct 21, 2022
Member
|
Seems like a small lint error, but otherwise lgtm |
Xunzhuo
reviewed
Oct 21, 2022
Member
There was a problem hiding this comment.
https://github.com/envoyproxy/gateway/blob/main/docs/conf.py#L35
Dont forget to remove the '+ fullversion' at the end. This is not ready too.
From:
copyright = 'Envoy Gateway Project Authors | GitHub | ' + fullversion
Too:
copyright = 'Envoy Gateway Project Authors | GitHub '
Others LGTM.
Member
|
I suggest waiting for #639, after getting that merged, I think most of changes in this PR will not be needed. |
Contributor
Author
|
Marking as Draft due to #640 (comment). |
Signed-off-by: danehans <daneyonhansen@gmail.com>
ac33802 to
7c87b0f
Compare
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## main #640 +/- ##
==========================================
- Coverage 63.59% 63.40% -0.20%
==========================================
Files 47 47
Lines 5749 5749
==========================================
- Hits 3656 3645 -11
- Misses 1868 1877 +9
- Partials 225 227 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the docs interface by:
Signed-off-by: danehans daneyonhansen@gmail.com